New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "remove upload photo step if using default avatar" #45849

Closed

mountiny wants to merge 1 commit into main from revert-44702-feat/direct-upload

Contributor

mountiny commented Jul 20, 2024 •

edited

Loading

Reverts #44702

Testing if this revert will fix:

Fixed Issues

Tests

First set of tests:

Open the app.
Click on the (+) plus icon and choose "Start Chat"
Select multiple people to add to the group.
Click on "Next"
Click on the avatar and upload an image.
After uploading, click on "View photo"
Remove the image and upload it again.
Create the group and check the header.
Verify that the group name in the header does not say "Chat report"

Screen.Recording.2024-07-20.at.23.23.13.mp4

Second set:


          Revert "remove upload photo step if using default avatar"

0bef871

mountiny added the Ready To Build label

mountiny self-assigned this

Contributor

github-actions bot commented Jul 20, 2024

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/45849/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/45849/NewExpensify.dmg	https://45849.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

Contributor Author

mountiny commented Jul 21, 2024

At the end it seems like the revert did not fix any of those

mountiny closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels