-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: displaying export button #45678
fix: displaying export button #45678
Conversation
I've opened it for review. I hope that I correctly understood the instructions :D |
I think that @hungvu193 would be a great candidate to review this, as he already has context by reviewing the offending PR :D |
Sure. Since I worked with @kosmydel in the offending PR. I'll handle it here. |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-07-21.at.15.07.39.movAndroid: mWeb ChromeScreen.Recording.2024-07-21.at.15.08.17.moviOS: NativeScreen.Recording.2024-07-21.at.15.03.29.moviOS: mWeb SafariScreen.Recording.2024-07-21.at.15.00.16.movMacOS: Chrome / SafariScreen.Recording.2024-07-21.at.14.42.53.movMacOS: DesktopScreen.Recording.2024-07-21.at.14.47.33.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Straight forward 🚀 LGTM
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/arosiclair in version: 9.0.11-0 🚀
|
🚀 Cherry-picked to staging by https://github.com/francoisl in version: 9.0.11-2 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/francoisl in version: 9.0.11-5 🚀
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.0.12-0 🚀
|
Details
Fixed Issues
$ #45609
PROPOSAL: N/A
Tests
Single transaction:
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-07-19.at.18.42.47.mov
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2024-07-19.at.18.40.32.mov
MacOS: Desktop