Deploy iOS to production when deploying other platforms #4567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roryabraham
approved these changes
Aug 11, 2021
MariaHCD
approved these changes
Aug 12, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
This was referenced Aug 12, 2021
|
@AndrewGable can this be checked off the list? |
|
Yes - You can check this one off, thank you! Noting here that this is the run: https://github.com/Expensify/App/runs/3353546458?check_suite_focus=true Doesn't look like it worked as expected, but I will create a follow up issue |
|
Actually, looks like the code wasn't updated yet.. So we have to wait to test this: https://github.com/Expensify/App/actions/runs/1140313603/workflow#L211-L214 |
|
🚀 Deployed to production by @roryabraham in version: 1.0.86-11 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
For some reason we cannot remember, we were not running iOS deploys when we were deploying every other platform to production. This code change will allow iOS to be deployed to production automatically.
Tests