Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require restricted business checkbox on CompanyStep #4531

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

Jag96
Copy link
Contributor

@Jag96 Jag96 commented Aug 10, 2021

Details

This PR adds a check to ensure the user can't continue on the Company Step of the VBA flow if the checkbox isn't checked.

Fixed Issues

Follow up PR to the issue found here: #4479 (comment)
cc @kevinksullivan

Tests/QA

  1. Navigate to the company step in the VBA flow: <baseURL>/bank-account/company.
  2. These are the fields that need to be filled out in order for the "Save & Continue" button to be enabled. Verify that the button is disabled if any of these fields aren't filled out. You don't need to input a valid value, any value will suffice as long as it isn't empty:
    • Legal Business Name
    • Company Address
    • City (for company address)
    • State (for company address)
    • Zip Code (for company address)
    • Company Website
    • Tax ID Number
    • Incorporation Date
    • Incorporation State
    • Industry Classification Code
    • Expensify Password
    • Checkbox at the bottom

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

@Jag96 Jag96 self-assigned this Aug 10, 2021
@Jag96 Jag96 requested a review from a team as a code owner August 10, 2021 19:10
@MelvinBot MelvinBot requested review from nickmurray47 and removed request for a team August 10, 2021 19:11
@Jag96 Jag96 requested a review from NikkiWines August 10, 2021 19:11
Copy link
Contributor

@nickmurray47 nickmurray47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@NikkiWines NikkiWines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@NikkiWines NikkiWines merged commit 75a1fe0 into main Aug 10, 2021
@NikkiWines NikkiWines deleted the joe-required-checkbox branch August 10, 2021 22:23
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @NikkiWines in version: 1.0.83-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @isagoico in version: 1.0.85-9 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants