-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Report Next Steps Audit] Simplify the App optimistic next steps #45160
[Report Next Steps Audit] Simplify the App optimistic next steps #45160
Conversation
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
I believe I have answered the remaining questions @rayane-djouah @eVoloshchak |
Updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! @eVoloshchak can you please give this a final look again? thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@mountiny all yours! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Vit Horacek <36083550+mountiny@users.noreply.github.com>
Some questions on these, based on what I've been doing on the backend. Probably more for @mountiny than for @rayane-djouah:
Otherwise it's looking good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this works for me! We may find some mismatches between the optimistic front and what gets sent from the backend once this is all complete but this should be 99% of the way there if not fully.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice yeah I agree we can clean those up later, thank you very much everyone!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.11-0 🚀
|
🚀 Cherry-picked to staging by https://github.com/francoisl in version: 9.0.11-2 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/francoisl in version: 9.0.11-5 🚀
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.0.12-0 🚀
|
Details
Uses a new simplified next steps format (new copy and replaced "Next Step" and "Finished!" labels with icons). Please refer to the Update Report Next Steps design doc.
Fixed Issues
$ #44784
Tests
Note: Since we test how optimistic data works, I recommend to enable slow Internet or offline mode.
Pre requirements:
1. Generates an optimistic nextStep once a report has been OPENED
1. Self review
2. Scheduled submit enabled
Format:
Waiting for [userSubmitter]'s expense(s) to automatically submit on [scheduleSubmitSetting]
Daily
: "Waiting for [userSubmitter]'s expense(s) to automatically submit later today";Weekly
: "Waiting for [userSubmitter]'s expense(s) to automatically submit on Sunday";Twice
a month: "Waiting for [userSubmitter]'s expense(s) to automatically submit on the 1st and 16th of each month";Monthly
: "Waiting for [userSubmitter]'s expense(s) to automatically submit on the [Selected report submission date] of each month";Trip
: "Waiting for [userSubmitter]'s expense(s) to automatically submit at the end of their trip";2. Generates an optimistic
nextStep
once a report has been SUBMITTEDFormat: Waiting for [userApprover] to approve expense(s)
1. Self review
2. Another reviewer
3. Another owner
3. Generates an optimistic
nextStep
once a report has been APPROVED1. Self review
2. Another owner
4. Generates an optimistic
nextStep
once a report has been PAID1. Paid with wallet
2. Paid outside of Expensify
Offline tests
Same as Tests.
QA Steps
Same as Tests.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-07-15.at.11.40.06.AM.mov
Android: mWeb Chrome
Screen.Recording.2024-07-15.at.11.36.46.AM.mov
iOS: Native
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-07-15.at.11.35.35.mp4
iOS: mWeb Safari
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-07-15.at.11.35.35.mp4
MacOS: Chrome / Safari
Screen.Recording.2024-07-12.at.10.54.37.AM.mov
Screen.Recording.2024-07-12.at.10.55.35.AM.mov
Screen.Recording.2024-07-12.at.10.56.21.AM.mov
Screen.Recording.2024-07-12.at.10.57.16.AM.mov
Untitled.mov
Screen.Recording.2024-07-12.at.11.41.42.AM.mov
MacOS: Desktop
Screen.Recording.2024-07-15.at.11.38.01.AM.mov