-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Stating] fix: app crashes when open the transaction thread report #45084
Conversation
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-07-09.at.8.14.18.PM.movAndroid: mWeb ChromeScreen.Recording.2024-07-09.at.8.13.05.PM.moviOS: NativeScreen.Recording.2024-07-09.at.8.11.44.PM.moviOS: mWeb SafariScreen.Recording.2024-07-09.at.8.10.44.PM.movMacOS: Chrome / SafariScreen.Recording.2024-07-09.at.8.07.14.PM.movMacOS: DesktopScreen.Recording.2024-07-09.at.8.09.13.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works good!
fix: app crashes when open the transaction thread report (cherry picked from commit bc85d26)
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.5-10 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 9.0.5-12 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀
|
🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀
|
Details
App crashes when open the transaction thread report
Fixed Issues
$ #44960
PROPOSAL: #44960 (comment)
Tests
Offline tests
Same as above
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-07-09.at.21.46.25.mov
Android: mWeb Chrome
Screen.Recording.2024-07-09.at.21.42.11.mov
iOS: Native
Screen.Recording.2024-07-09.at.21.45.16.mov
iOS: mWeb Safari
Screen.Recording.2024-07-09.at.21.43.09.mov
MacOS: Chrome / Safari
Screen.Recording.2024-07-09.at.21.40.59.mp4
MacOS: Desktop
Screen.Recording.2024-07-09.at.21.49.42.mp4