-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update logic of filtering created actions from transaction thread report #44946
fix: update logic of filtering created actions from transaction thread report #44946
Conversation
…d report in getCombinedReportActions function Signed-off-by: dominictb <tb-dominic@outlook.com>
Co-authored-by: c3024 <102477862+c3024@users.noreply.github.com>
I am seeing a continuous call of getOlderActions.mp4 |
@c3024 I do not get this issue. Can you clear cache and disable the strict mode to see if it makes any difference? |
Co-authored-by: c3024 <102477862+c3024@users.noreply.github.com>
Reviewer Checklist
Screenshots/VideosAndroid: Native![createdAndroid](https://github.com/user-attachments/assets/a38ad178-bda4-4916-b12c-f082a37c045d)MacOS: Chrome / SafaricreatedChrome.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Please remove this point from the Tests and QA tests.
|
done! |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/stitesExpensify in version: 9.0.7-3 🚀
|
🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 9.0.7-4 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.7-8 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.0.8-6 🚀
|
|
||
if (transactionThreadCreatedAction && parentReportCreatedAction && transactionThreadCreatedAction.created > parentReportCreatedAction.created) { | ||
filteredTransactionThreadReportActions = transactionThreadReportActions?.filter((action) => action.actionName !== CONST.REPORT.ACTIONS.TYPE.CREATED); | ||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When there are some replies in the single transaction view and we delete the request, it shows skeleton loader even though all messages are loaded. #45461
Details
fix: update logic of filtering created actions from transaction thread report in case the transaction thread is created before the IOU thread
Fixed Issues
$ #42795
PROPOSAL: #42795 (comment)
Tests
Verify that: Only one expense should be submitted, and the UI should not cover the notification
Offline tests
QA Steps
Verify that: Only one expense should be submitted, and the UI should not cover the notification
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
On main branch
On this branch (Issue fixed)
MacOS: Desktop