[Search] Selection Mode for small screens #44820

filip-solecki · 2024-07-04T12:12:12Z

Details

Fixed Issues

$ #44577
PROPOSAL:

Tests

Log in to the app
Go to Search
Make sure you have various types of expenses etc.
Simulate small screen (if you are using desktop or web)
Long press some item
Make sure everything works as expected

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android.mp4

Android: mWeb Chrome

Android_chrome.mp4

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Plus.-.2024-07-05.at.15.38.07.mp4

iOS: mWeb Safari

iOS_Safari.mp4

MacOS: Chrome / Safari

Web.mov

MacOS: Desktop

Desktop.mov

filip-solecki · 2024-07-04T17:16:22Z

I opened PR according to Slack convo - I will fill checklist and upload videos tomorrow

melvin-bot · 2024-07-04T17:16:47Z

@mkhutornyi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rushatgabhane · 2024-07-05T12:52:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-07-05.at.18.02.48.mov

Android: mWeb Chrome

iOS: Native

Screen.Recording.2024-07-05.at.18.00.38.mov

iOS: mWeb Safari

Screen.Recording.2024-07-05.at.18.03.36.mov

MacOS: Chrome / Safari

MacOS: Desktop

Screen.Recording.2024-07-05.at.18.06.25.mov

rushatgabhane

@filip-solecki should we maintain the list of selected items when switching from mobile to desktop layout? If not in this PR, we should create an issue

Screen.Recording.2024-07-05.at.16.25.18.mov

filip-solecki · 2024-07-05T13:43:08Z

It would probably be a good idea to do this

shawnborton · 2024-07-05T14:46:45Z

Looks like the button isn't using bold text?

Can you make sure we're using our normal button components here?

rushatgabhane

LGTM!

Created a follow-up issue for the above items as they're unrelated to the PR.
#44916

shawnborton · 2024-07-05T15:13:59Z

Hmm can we please fix the bold button in this PR? That doesn't exist anywhere else AFAIK.

rushatgabhane · 2024-07-05T15:16:33Z

@shawnborton okayy def! @filip-solecki all yours

rushatgabhane · 2024-07-05T15:17:32Z

src/pages/Search/SearchSelectedNarrow.tsx

+                {({hovered}) => (
+                    <Animated.View style={[styles.tabSelectorButton, styles.tabBackground(hovered, true, theme.border), styles.w100, styles.mh3]}>
+                        <View style={[styles.flexRow]}>
+                            <Text>{translate('workspace.common.selected', {selectedNumber: itemsLength})}</Text>


styles.bold here?

Interesting, why does this use a custom component and not some kind of extension of our standard button components? Otherwise we run into issues just like this where we have inconsistent styles between buttons.

Changed to Button

trjExpensify · 2024-07-05T15:19:04Z

So the cleanup issue is just for maintaining the selected items when moving from small to wide screens (and the other way around)?

rushatgabhane · 2024-07-05T15:27:33Z

yes for maintaining selected items only

filip-solecki · 2024-07-08T10:49:20Z

@rlinoz I think it is all yours now!

shawnborton · 2024-07-08T12:55:34Z

Let's fire up a test build, too.

filip-solecki · 2024-07-10T06:18:03Z

I tried multiple times and couldn't reporduce it, is it happening for you all the time you click on item in Selection Mode?

@filip-solecki yep, happens every time. Video from the latest build:

Screen.Recording.2024-07-09.at.14.51.27.mov

Really weird - it does not exist for me even on the same build and I am using Chrome too

trjExpensify · 2024-07-10T11:59:29Z

I can repro the issue Rodrigo is seeing on the build linked above.

2024-07-10_12-52-28.mp4

I'm running a new build now for the avoidance of doubt.

filip-solecki · 2024-07-10T12:23:07Z

I can reproduce it right now, I am working on some solution

github-actions · 2024-07-10T12:33:34Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/44820/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/44820/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/44820/NewExpensify.dmg	https://44820.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

filip-solecki · 2024-07-10T12:35:19Z

exists also on new build, working on it

filip-solecki · 2024-07-10T13:41:41Z

@trjExpensify @rlinoz
It is fixed - please run a new build and test it!

rlinoz · 2024-07-10T14:30:40Z

Triggered a new build

github-actions · 2024-07-10T15:03:43Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/44820/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/44820/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/44820/NewExpensify.dmg	https://44820.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

rlinoz · 2024-07-10T15:15:12Z

It is fixed for me now!

trjExpensify · 2024-07-10T16:19:42Z

Same here, nice!

rlinoz · 2024-07-10T17:02:01Z

Sorry, I was about to merge and realized we are not dismissing the bulk actions modal after executing the action.

Screen.Recording.2024-07-10.at.14.00.25.mov

#44820 (comment)

filip-solecki · 2024-07-11T05:16:42Z

@rlinoz Done

OSBotify · 2024-07-11T10:26:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-15T21:05:14Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.0.7-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-15T22:13:58Z

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 9.0.7-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-17T00:20:34Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.7-8 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-07-18T13:50:44Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.8-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

allroundexperts · 2024-07-28T21:53:36Z

src/pages/Search/SearchSelectedNarrow.tsx

+            <Button
+                onPress={openMenu}
+                ref={buttonRef}
+                style={[styles.w100, styles.ph5]}
+                text={translate('workspace.common.selected', {selectedNumber: itemsLength})}
+                shouldShowRightIcon
+                isContentCentered
+                iconRight={Expensicons.DownArrow}
+            />


We forgot to disable this button when options.length were 0. This caused #45445

filip-solecki added 2 commits July 4, 2024 14:11

Add Selection Mode for small screens in Search Page

4832073

revert podfile changes

57ed2ba

filip-solecki mentioned this pull request Jul 4, 2024

[HOLD for payment 2024-07-24] [$250] [CSV] Add Selection mode to Search page #44577

Closed

filip-solecki marked this pull request as ready for review July 4, 2024 17:16

filip-solecki requested a review from a team as a code owner July 4, 2024 17:16

melvin-bot bot removed the request for review from a team July 4, 2024 17:16

melvin-bot bot requested a review from mkhutornyi July 4, 2024 17:16

rlinoz self-requested a review July 4, 2024 17:36

filip-solecki added 3 commits July 5, 2024 14:11

Merge branch 'main' into search/selection-mode

0aecf72

Fix icon for selected button

3b3b2b7

Fix icon

d3a7f9e

trjExpensify requested review from rushatgabhane and removed request for mkhutornyi July 5, 2024 12:29

rushatgabhane suggested changes Jul 5, 2024

View reviewed changes

rushatgabhane mentioned this pull request Jul 5, 2024

[HOLD for payment 2024-08-13] [HOLD for payment 2024-08-09] [Search] Cleanups from #44820 #44916

Closed

rushatgabhane approved these changes Jul 5, 2024

View reviewed changes

rushatgabhane reviewed Jul 5, 2024

View reviewed changes

Use Button Component

6cf4194

shawnborton added the Ready To Build label Jul 8, 2024

Remove redundant props passing

789ad91

Merge branch 'main' into search/selection-mode

b51eaec

Fix broken Pressable props

212ddc1

rlinoz previously approved these changes Jul 10, 2024

View reviewed changes

Leave Selection Mode after action fires

6899d60

Fix lint

29fc205

rlinoz approved these changes Jul 11, 2024

View reviewed changes

rlinoz merged commit 978b833 into Expensify:main Jul 11, 2024
14 checks passed

github-actions bot mentioned this pull request Jul 15, 2024

Deploy Checklist: New Expensify 2024-07-15 #45421

Closed

m-natarajan mentioned this pull request Jul 16, 2024

[HOLD for payment 2024-07-25] [HOLD for payment 2024-07-24] iOS - Search - "No options available for the selected group of expenses." is truncated #45444

Closed

6 tasks

allroundexperts reviewed Jul 28, 2024

View reviewed changes

allroundexperts mentioned this pull request Jul 28, 2024

[HOLD for payment 2024-07-24] iOS - Search - Empty modal is shown when tapping on "0 selected" dropdown #45445

Closed

6 tasks

[Search] Selection Mode for small screens #44820

[Search] Selection Mode for small screens #44820

Conversation

filip-solecki commented Jul 4, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

filip-solecki commented Jul 4, 2024

melvin-bot bot commented Jul 4, 2024

rushatgabhane commented Jul 5, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

rushatgabhane left a comment • edited Loading

Choose a reason for hiding this comment

filip-solecki commented Jul 5, 2024

shawnborton commented Jul 5, 2024

rushatgabhane left a comment • edited Loading

Choose a reason for hiding this comment

shawnborton commented Jul 5, 2024

rushatgabhane commented Jul 5, 2024

rushatgabhane Jul 5, 2024 • edited Loading

Choose a reason for hiding this comment

shawnborton Jul 5, 2024

Choose a reason for hiding this comment

filip-solecki Jul 8, 2024

Choose a reason for hiding this comment

shawnborton Jul 8, 2024

Choose a reason for hiding this comment

trjExpensify commented Jul 5, 2024

rushatgabhane commented Jul 5, 2024

filip-solecki commented Jul 8, 2024

shawnborton commented Jul 8, 2024

filip-solecki commented Jul 10, 2024

trjExpensify commented Jul 10, 2024

filip-solecki commented Jul 10, 2024

github-actions bot commented Jul 10, 2024

filip-solecki commented Jul 10, 2024

filip-solecki commented Jul 10, 2024

rlinoz commented Jul 10, 2024

github-actions bot commented Jul 10, 2024

rlinoz commented Jul 10, 2024

trjExpensify commented Jul 10, 2024

rlinoz commented Jul 10, 2024

filip-solecki commented Jul 11, 2024

OSBotify commented Jul 11, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 17, 2024

OSBotify commented Jul 18, 2024

allroundexperts Jul 28, 2024

Choose a reason for hiding this comment

filip-solecki commented Jul 4, 2024 •

edited

Loading

rushatgabhane commented Jul 5, 2024 •

edited

Loading

rushatgabhane left a comment •

edited

Loading

rushatgabhane left a comment •

edited

Loading

rushatgabhane Jul 5, 2024 •

edited

Loading