Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't allow invalid characters #4478

Merged
merged 3 commits into from
Aug 12, 2021

Conversation

aman-atg
Copy link
Contributor

@aman-atg aman-atg commented Aug 6, 2021

Details

#4217 (comment)

Fixed Issues

$ #4217

Tests || QA Steps

  1. Login to newDot
  2. Go to Profile
  3. Click on Add Phone Number
  4. Try to add english letters and it'll not let you do that

Tested On

  • Web
  • Mobile Web
  • Android
  • Please test on these two
  • Desktop
  • iOS

Screenshots

Web

image

Mobile Web

mWeb

Desktop

iOS

Android

mobile

@aman-atg aman-atg requested a review from a team as a code owner August 6, 2021 22:30
@aman-atg aman-atg marked this pull request as draft August 6, 2021 22:31
@MelvinBot MelvinBot requested review from pecanoro and removed request for a team August 6, 2021 22:31
@pecanoro pecanoro merged commit bac9675 into Expensify:main Aug 12, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @pecanoro in version: 1.0.85-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@botify
Copy link

botify commented Aug 25, 2021

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-01. 🎊

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.0.86-11 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@botify
Copy link

botify commented Aug 30, 2021

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-06. 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants