-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dismiss violation action in review duplication feat #44711
Conversation
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-07-03.at.17.30.59.movAndroid: mWeb ChromeScreen.Recording.2024-07-03.at.17.17.51.moviOS: NativeScreen.Recording.2024-07-03.at.17.29.11.moviOS: mWeb SafariScreen.Recording.2024-07-03.at.17.26.13.movMacOS: Chrome / SafariScreen.Recording.2024-07-03.at.17.06.34.movMacOS: DesktopScreen.Recording.2024-07-03.at.17.34.35.mov |
@dominictb You should remove the |
@dukenv0307 ready for review now. |
code looks good and tests well |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/Gonals in version: 9.0.5-0 🚀
|
🚀 Deployed to staging by https://github.com/Gonals in version: 9.0.5-2 🚀
|
This PR is failing because of issue #44197 The issue is reproducible in: 1720447238029.2024-07-08_16_58_30.mp4mweb 1720453962345.Screen_Recording_20240708_185204_Chrome.mp4Android 1720454179043.Screen_Recording_20240708_185551_New_Expensify.mp4IOS 1720469010702.RPReplay_Final1720468963.1.mp4Desktop 1720458140186.resolve_greyed_out.mp4 |
@dukenv0307 seems like the problem with BE just as I reported. |
🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀
|
🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀
|
Details
Fixed Issues
$ #44197
PROPOSAL: #44197 (comment)
Tests
Prerequisite: Enable DUPE_DETECTION betaVerify that:
In Step 8, the resolved duplicate system message will be copied.
In Step 9, the thread view for resolved duplicate system message will not gray out.
Verify that no errors appear in the JS console
Offline tests
QA Steps
Verify that:
In Step 8, the resolved duplicate system message will be copied.
In Step 9, the thread view for resolved duplicate system message will not gray out.
Verify that no errors appear in the JS console
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
compressed_web.mov.mp4
MacOS: Desktop