Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: LHN of self-DM still shows actionable whisper after submitted #44684

Merged
merged 2 commits into from
Jul 15, 2024
Merged

fix: LHN of self-DM still shows actionable whisper after submitted #44684

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49272b0
fix: LHN of self-DM still shows actionable whisper after submitted
dominictb Jul 1, 2024
120fbd3
fix: minor change in logic
dominictb Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/libs/ReportActionsUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -681,7 +681,8 @@ function isActionableTrackExpense(reportAction: OnyxInputOrEntry<ReportAction>):
*
*/
function isResolvedActionTrackExpense(reportAction: OnyxEntry<ReportAction>): boolean {
const resolution = reportAction && 'resolution' in reportAction ? reportAction?.resolution : null;
const originalMessage = getOriginalMessage(reportAction);
const resolution = originalMessage && 'resolution' in originalMessage ? originalMessage?.resolution : null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before accessing the 'resolution' in originalMessage, we should have checked the typeof originalMessage, and if it's an object, then we should have accessed the 'resolution'. Directly accessing the 'resolution' causes this crash when we get the system message for exporting to CSV.

return isActionableTrackExpense(reportAction) && !!resolution;
}

Expand Down
Loading