Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump test: Point Onyx to a forked branch #44659

Closed

Conversation

paultsimura
Copy link
Contributor

@paultsimura paultsimura commented Jun 29, 2024

Details

This PR is intended to test the Onyx changes from Expensify/react-native-onyx#490

OSBotify and others added 13 commits June 27, 2024 16:30
(cherry picked from commit 344e5bf)
…eze-screen-with-lazy-loading

[CP Staging] Add freezeScreenWithLazyLoading function

(cherry picked from commit 9d88c63)
(cherry picked from commit d5ceeef)
[CP Staging] Skip ReanimatedCommitMarker assertion in RNReanimated

(cherry picked from commit 4af2b3f)
…k-staging-44555-1

🍒 Cherry pick PR Expensify#44555 to staging 🍒
(cherry picked from commit 6501d00)
…itle-doesnt-update

[CP Staging] Fix thread title not updated in header and in LHN after editing parent message

(cherry picked from commit b26b9b1)
(cherry picked from commit 5ee9922)
[CP Staging] Default to -1 in report header details

(cherry picked from commit 11333a3)
(cherry picked from commit 874b65e)
…apper

[CP Stg] Replace ReportScreenIDSetter with useLastAccessedReportID

(cherry picked from commit 359dbe6)
@paultsimura paultsimura requested a review from a team as a code owner June 29, 2024 11:00
@melvin-bot melvin-bot bot requested review from stitesExpensify and removed request for a team June 29, 2024 11:01
Copy link

melvin-bot bot commented Jun 29, 2024

@stitesExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@paultsimura
Copy link
Contributor Author

@tgolen this is a new PR for testing the Onyx update() changes. It's pointed to the production branch to minimize potential unrelated bugs.

@tgolen
Copy link
Contributor

tgolen commented Jul 1, 2024

OK, I'm generating the adhoc build for it right now and it should post once it's done. I'm reaching out to the QA team to ask them about bandwidth to test it this week. Are there any specific areas/flows/platforms you would like to have them test specifically? If so, please list them here so they can refer to them.

Copy link
Contributor

github-actions bot commented Jul 1, 2024

@paultsimura
Copy link
Contributor Author

Are there any specific areas/flows/platforms you would like to have them test specifically? If so, please list them here so they can refer to them.

Nothing specific, just general work with money requests. It would also be good to test doing some operations offline and then coming back online (as these operations are squashed into one update())

@tgolen
Copy link
Contributor

tgolen commented Jul 2, 2024

OK, thanks! I have reached out to QA to have testing scheduled for this. More than likely, it will happen next week as there are some other ad-hoc builds currently being tested.

@mvtglobally
Copy link

Regression is completed on Web and Android. No build specific issues found

@OSBotify OSBotify force-pushed the production branch 2 times, most recently from 12b1dd7 to 7253259 Compare July 8, 2024 09:23
@paultsimura
Copy link
Contributor Author

Hi @mvtglobally, since Tim is currently OOO, could you please clarify if the QA will be performed on all the remaining platforms (besides Web and Android)?

@tgolen
Copy link
Contributor

tgolen commented Jul 15, 2024

@paultsimura I only requested for QA to test on web and 1 native platform to speed up testing. I think any regressions would have been caught with only those two platforms. They aren't planning to test any others.

Since their testing didn't reveal any issues, I think it's OK to move forward with merging your change in Onyx and then bumping the Onyx version in App to officially roll it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants