-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pending / Scanning] Fix Optimistic ReportID for Instant submit / No Approvers #44612
Conversation
@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Author checklist is remaining.
Could you also please add QA steps
Was working on the Auth PR, will come back to updating this one |
@MonilBhavsar updated |
@MariaHCD or @Beamanator are either of you down to final review this while @MonilBhavsar is OOO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
1 similar comment
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/dangrous in version: 9.0.5-0 🚀
|
🚀 Deployed to staging by https://github.com/dangrous in version: 9.0.5-2 🚀
|
@grgia Can you please specify how QA team can create a pending expensify card transaction? |
🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀
|
🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀
|
Details
Problem:
Manual Requests were calculating the wrong reportID from the FE, bypassing the changes for calculating the reportID in the BE. This resulted in Manual Requests being added to Processing Non-Reimbursable reports on Instant Submit/No Approvers.
Solution:
If the policy is Instant Submit / No Approvers, we will ignore reports with only nonreimbursable reports when determining the optimistic report to add the manual request to.
Fixed Issues
$ #44614
Tests
Pre-reqs
Create a Policy with Instant Submit / No Approvers Settings.
Create an employee on that policy. Give the employee an ECard.
See SO for Clitools commands https://stackoverflowteams.com/c/expensify/questions/6430/6431#6431
(INTERNAL)
Offline tests
QA Steps
Pre-Reqs:
Create a policy, set to Instant Submit Enabled and No Approvers
Create an employee, give them an expensify card.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop