-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clear policy errors #44130
Merged
Merged
clear policy errors #44130
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
f2efad0
clear policy errors
Nodebrute 143dd13
Merge branch 'Expensify:main' into policyErrors
Nodebrute 196f16f
remove errors
Nodebrute 4a02aee
fix lint
Nodebrute e875e3f
Merge branch 'Expensify:main' into policyErrors
Nodebrute a0202fe
Merge branch 'main' into policyErrors
Nodebrute 72518c1
fix reportName error
Nodebrute e340e43
remove rbr from settings
Nodebrute 0befef8
fix lint errors
Nodebrute 2ff95e0
Merge branch 'Expensify:main' into policyErrors
Nodebrute 671f6cd
Merge branch 'Expensify:main' into policyErrors
Nodebrute f049a8b
import localize
Nodebrute File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure how our problem gets solved by not setting
errors
here. The problem mentioned here still exists. WhenopenReport
is called,errorFields
comes back as follows with null (as shown below) and, strangely, FE resets theerrorFields
in report in Onyx. Don’t we need to get to the bottom of this?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Investigating
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rojiphil Hey, I'm still unable to reproduce the issue you're mentioning with RBR. You can check the video below. Even after the
openReport
calls, the RBR isn't disappearing. I've also tried reloading the page, but the RBR remains until we manually remove it by pressing the cross. Please let me know if I am missing any stepScreen.Recording.2024-07-22.at.1.54.12.PM.1.1.1.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to set
errors
here. The backend returnserrorFields
in case of failure, which is sufficient to display errors here. We don't even set errors when updating the room name. I don't think we need to includeerrors
in the failure data when updating the group name. Removing errors seems to address the main issue of removing RBR after pressing the cross. Let me know your thoughts.App/src/libs/actions/Report.ts
Lines 2293 to 2305 in eec4d6a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rojiphil Additionally, the backend is returning the merge method, so it is not affecting the existing errorFields in the Onyx.
Screen.Recording.2024-07-22.at.2.41.36.PM.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good cleanup. Earlier as mentioned here
settings
also had a provision to update room name. But, now, since editing the room name is no longer present withinsettings
page, we can avoid setting GBR forsettings
menu.