Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't show localTime for Chronos #4403

Merged
merged 1 commit into from
Aug 5, 2021

Conversation

aman-atg
Copy link
Contributor

@aman-atg aman-atg commented Aug 3, 2021

Details

Comment

Fixed Issues

$ #4342

Tests || ### QA Steps

Tested On

  • Web
  • Mobile Web
  • Android
  • Can't test on these two
  • Desktop
  • iOS

Screenshots

Web

image

Mobile Web

image

Desktop

iOS

Android

image

@aman-atg aman-atg requested a review from a team as a code owner August 3, 2021 23:18
@MelvinBot MelvinBot requested review from Beamanator and removed request for a team August 3, 2021 23:18
@aman-atg aman-atg marked this pull request as draft August 3, 2021 23:18
@aman-atg aman-atg marked this pull request as ready for review August 4, 2021 21:51
Copy link
Contributor

@Beamanator Beamanator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Also I tested on iOS and Desktop, looks good 👍

Screen Shot 2021-08-05 at 3 14 02 PM
Screen Shot 2021-08-05 at 3 16 25 PM

@Beamanator Beamanator merged commit 0b1b35c into Expensify:main Aug 5, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Aug 5, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Aug 6, 2021

🚀 Deployed to staging in version: 1.0.82-8🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @francoisl in version: 1.0.83-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@aman-atg aman-atg deleted the aman-atg-chronosTimezone branch August 12, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants