-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Hide whisper action when deleting track expense in offline #43977
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@truph01 Thanks for the PR. I have left few comments for your consideration. Please have a look.
@rojiphil I addressed all your comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@truph01 Thanks for the PR. I have left few comments. Please have a look.
@rojiphil I resolved all your comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @truph01. I have left few more comments. But looks pretty close. Please have a look.
Co-authored-by: Roji Philip <rojiphil@gmail.com>
@rojiphil I addressed your comments. |
@rojiphil Can you check my PR again? |
@rojiphil PR is updated |
Reviewer Checklist
Screenshots/VideosMacOS: Chrome / Safari43977-web-safari-002.mp4MacOS: Desktop43977-desktop-002.mp4Android: Native43977-android-native-002.mp4Android: mWeb Chrome43977-mweb-chrome-002.mp4iOS: Native43977-ios-native-002.mp4iOS: mWeb Safari43977-mweb-safari-002.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @truph01 for the changes. Code LGTM.
And tests well too.
@truph01 Sorry. Forgot to mention this change in the test steps. Please replace the following with 7 Verify that the actionable whisper is not displayed. |
@rojiphil I updated test steps |
Nice job with this! |
🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.0.4-0 🚀
|
🚀 Cherry-picked to staging by https://github.com/tgolen in version: 9.0.4-5 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀
|
🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀
|
Details
Fixed Issues
$ #43560
PROPOSAL: #43560 (comment)
Tests
7 Verify that the actionable whisper is not displayed.
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-06-19.at.14.10.20.mov
Android: mWeb Chrome
Screen.Recording.2024-06-19.at.14.07.59.mov
iOS: Native
Screen.Recording.2024-06-19.at.14.11.20.mov
iOS: mWeb Safari
Screen.Recording.2024-06-19.at.14.05.03.mov
MacOS: Chrome / Safari
output.mp4
MacOS: Desktop