Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO QA] Clarify risk of submitting early proposals #4391

Merged
merged 2 commits into from
Aug 3, 2021

Conversation

Beamanator
Copy link
Contributor

Details

Purpose: Update phrasing in CONTRIBUTING.md to encourage people not to post solutions before an issue is marked External.

Discussion in Slack here.

Fixed Issues

N/A

Tests

N/A

QA Steps

N/A

@Beamanator Beamanator requested a review from a team August 3, 2021 12:40
@Beamanator Beamanator self-assigned this Aug 3, 2021
@MelvinBot MelvinBot requested review from MonilBhavsar and removed request for a team August 3, 2021 12:41
@Beamanator Beamanator changed the title [NO QA] Clarify situation of early proposals [NO QA] Clarify risk of submitting early proposals Aug 3, 2021
@Beamanator Beamanator requested a review from a team as a code owner August 3, 2021 12:45
@MelvinBot MelvinBot requested review from TomatoToaster and removed request for a team August 3, 2021 12:45
@TomatoToaster TomatoToaster merged commit e285a49 into main Aug 3, 2021
@TomatoToaster TomatoToaster deleted the beaman-clarifyProposalTiming branch August 3, 2021 15:19
@OSBotify
Copy link
Contributor

OSBotify commented Aug 3, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Aug 6, 2021

🚀 Deployed to staging in version: 1.0.82-8🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @francoisl in version: 1.0.83-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants