expensify-common hash update #4349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
Oops, looks like there is conflicts. Can you resolve them? Additionally, I think the commit should be Expensify/expensify-common@4016a78 (the merge commit hash) |
10 tasks
|
@AndrewGable I got some trouble solving the conflicts but I think now its ok and updated hash is ready for merging! 😅 |
AndrewGable
approved these changes
Aug 3, 2021
|
I will merge once e2e tests pass (probably tomorrow morning!) |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
This was referenced Aug 3, 2021
|
🚀 Deployed to staging in version: 1.0.82-8🚀
|
|
🚀 Deployed to production by @francoisl in version: 1.0.83-1 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AndrewGable will you please review this?
Hash update of expensify-common
Creation of html -> markdown conversion of inlineCodeBlock
Fixed Issues
#4185
Tests
WhatsApp.Video.2021-07-29.at.19.00.28.mp4
Unit test were added to tests/ExpensiMark-Markdown-test.js
QA