chore(bump-e-common): Updated expensify-common ref hash

[mananjadhav]

@andreacastejon can you please review this?

Details

• Merges hyperlink changes from expensify-common to the App

Fixed Issues

$ Fixes App/4229

Tests

QA Steps

1. Type [Yo (click here to see a cool cat)](https://c8.alamy.com/compes/ha11pc/cookie-cat-con-sombrero-de-cowboy-y-sun-glass-ha11pc.jpg) (without `)
2. Verify it hyperlinks correctly

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

md-hyperlink-web-screencast.mp4

Mobile Web

md-hyperlink-mobile-web-screencast.mp4

Desktop

md-hyperlink-desktop-screencast.mp4

iOS

md-hyperlink-ios-screencast.mp4

Android

md-hyperlink-android-screencast.mp4

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[mananjadhav]

I have read the CLA Document and I hereby sign the CLA

[timszot]

LGTM, leaving for @AndrewGable

[botify]

npm has a package.json file and a package-lock.json file. It seems you updated one without the other, which is usually a sign of a mistake. If you are updating a package make sure that you update the version in package.json then run npm install

[AndrewGable]

@mananjadhav - Screenshots look great. I updated with QA steps. Can you run npm install as the bot is asking?

[mananjadhav]

Just did and pushed

[mananjadhav]

@AndrewGable Some checks failed after my last commit. The lint errors are not even related to my changes.

[AndrewGable]

We will take a look into this- I agree it seems unrelated to your changes.

[mananjadhav]

Thanks. Let me know if you want my help with this.

[AndrewGable]

I updated my local main branch to have your hash git://github.com/Expensify/expensify-common.git#e83c6998dac6837098745139cb2bdd4e18bf7134 in package.json. These are the only changes I see in my diff are this:

diff --git a/package-lock.json b/package-lock.json
index 90dd382d8..af867b63d 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -23070,8 +23070,8 @@
       }
     },
     "expensify-common": {
-      "version": "git://github.com/Expensify/expensify-common.git#7d8408c5c78792394eee8e079f115b1380221a23",
-      "from": "git://github.com/Expensify/expensify-common.git#7d8408c5c78792394eee8e079f115b1380221a23",
+      "version": "git://github.com/Expensify/expensify-common.git#e83c6998dac6837098745139cb2bdd4e18bf7134",
+      "from": "git://github.com/Expensify/expensify-common.git#e83c6998dac6837098745139cb2bdd4e18bf7134",
       "requires": {
         "classnames": "2.3.1",
         "clipboard": "2.0.4",
diff --git a/package.json b/package.json
index 2c29e02b0..377a519f9 100644
--- a/package.json
+++ b/package.json
@@ -60,7 +60,7 @@
     "electron-log": "^4.3.5",
     "electron-serve": "^1.0.0",
     "electron-updater": "^4.3.4",
-    "expensify-common": "git://github.com/Expensify/expensify-common.git#7d8408c5c78792394eee8e079f115b1380221a23",
+    "expensify-common": "git://github.com/Expensify/expensify-common.git#e83c6998dac6837098745139cb2bdd4e18bf7134",
     "expo-haptics": "^10.0.0",
     "file-loader": "^6.0.0",
     "html-entities": "^1.3.1",

The package-lock.json diff that you pushed is a lot larger. This makes me think that you might not have the same npm version or node version leading to these errors. Can you double check that you have the same versions installed and see if you see the same?

andrew ➜ Expensify.cash npm --version
6.14.11
andrew ➜ Expensify.cash node --version
v14.16.0

[mananjadhav]

Yeah, I've got different versions here.

npm --version ---> 6.14.5
node --version ---> v12.16.1

Also, I did update npm today for another project.

[AndrewGable]

Ok can you install the versions I've listed and see if re-running npm install leaves you with a similar diff? Thanks.

[mananjadhav]

@AndrewGable I've raised a fresh PR removing my node_modules, etc. and I can match your diff. Closing this one.

#4283