Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[InternalQA] Update Workspace button text during pending account validation #4237

Merged
merged 1 commit into from
Aug 2, 2021

Conversation

luacmartins
Copy link
Contributor

@luacmartins luacmartins commented Jul 26, 2021

Details

cc @chiragsalian
cc @MitchExpensify

Fixed Issues

$ #4236

Tests

  1. Create a new Workspace.
  2. Follow these steps to add a PENDING account.
  3. When you get to the Validate step, verify that the button text changes to Finish Setup.
  4. When prompted for the 3 codes, follow these steps.
  5. Verify that the button text is set to Manage Cards and clicking it directs the user to expensify.com.

QA Steps

Internal QA.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web.mov

Mobile Web

Desktop

iOS

Android

@luacmartins luacmartins requested a review from a team July 26, 2021 21:27
@luacmartins luacmartins self-assigned this Jul 26, 2021
@MelvinBot MelvinBot requested review from marcaaron and removed request for a team July 26, 2021 21:27
merge conflicts
@luacmartins luacmartins requested a review from a team as a code owner August 2, 2021 18:08
@MelvinBot MelvinBot removed the request for review from a team August 2, 2021 18:08
@luacmartins
Copy link
Contributor Author

Updated! Solved conflicts.

@marcaaron marcaaron merged commit 497a65e into main Aug 2, 2021
@marcaaron marcaaron deleted the cmartins-manage-card branch August 2, 2021 19:17
@OSBotify
Copy link
Contributor

OSBotify commented Aug 2, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Aug 6, 2021

🚀 Deployed to staging in version: 1.0.82-8🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@roryabraham
Copy link
Contributor

Hey @luacmartins we currently don't have an internal QA checklist for NewDot, so you will need to remember to QA this on staging and check it off on the checklist if it passes.

@luacmartins
Copy link
Contributor Author

Thanks @roryabraham TIL! I confirmed the steps in QA, all good.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @francoisl in version: 1.0.83-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants