-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Wave Collect][Xero] Main export configuration #41554
Conversation
src/pages/workspace/accounting/xero/export/XeroExportConfigurationPage.tsx
Outdated
Show resolved
Hide resolved
src/pages/workspace/accounting/xero/export/XeroExportConfigurationPage.tsx
Outdated
Show resolved
Hide resolved
src/pages/workspace/accounting/xero/export/XeroExportConfigurationPage.tsx
Outdated
Show resolved
Hide resolved
Code changes look fine. I’ll finish the checklist in a few hours. |
Discussion point: I think the text we're using here feeds confusion and we shouldn't carry it over from OldDot. There's a setting in
We could make that text "dynamic", but we could also avoid it and make this clearer. I don't really see why we need to have the purchase bill status in a separate place in
That would get us this: Thoughts, @Expensify/design @zanyrenney? |
Yes, it'll be taken care in another issue that implements the push input page |
Added english copy from the docs I agree that we need to refine it |
Yeah, I still think it's incorrect. 😄 |
Co-authored-by: Rocio Perez-Cano <pecanoro@users.noreply.github.com>
…tionPage.tsx Co-authored-by: Hans <hungvu193@users.noreply.github.com>
Co-authored-by: Rocio Perez-Cano <pecanoro@users.noreply.github.com>
Co-authored-by: Rocio Perez-Cano <pecanoro@users.noreply.github.com>
Co-authored-by: Rocio Perez-Cano <pecanoro@users.noreply.github.com>
Co-authored-by: Rocio Perez-Cano <pecanoro@users.noreply.github.com>
@Expensify/design could you double check everything look correct? |
Where is the best place to find the latest screenshots? |
Starting to test now. |
Reviewer Checklist
Screenshots/Videos |
We did not find an internal engineer to review this PR, trying to assign a random engineer to #39735 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
@lakchote @pecanoro All yours.
@rushatgabhane Can you update the QA steps section to atleast mention same as |
The QA steps are super short, I am assuming that besides the page opening, we need to test the different options work? |
@pecanoro no, we don't need to test if the options work. They will be implemented in separate PRs |
@mananjadhav We are missing one checkbox in the checklist 😄 |
@pecanoro Just done. |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/lakchote in version: 1.4.72-0 🚀
|
🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.72-1 🚀
|
Details
Fixed Issues
$ #39735
PROPOSAL:
Tests
Pre-requisite:
Accounting
Beta andXero
beta.Test
Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
iOS: Native
Screen.Recording.2024-05-06.at.18.05.11.mov
iOS: mWeb Safari
https://github.com/Expensify/App/assets/29673073/6c97b770-38cb-4d6d-b403-c590b0ab9a1bMacOS: Chrome / Safari
MacOS: Desktop