-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] Add 300ms timeout between RHP and Training Video #41244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!!
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-04-30.at.3.01.05.AM.movAndroid: mWeb ChromeScreen.Recording.2024-04-30.at.2.59.15.AM.moviOS: NativeScreen.Recording.2024-04-30.at.2.57.59.AM.moviOS: mWeb SafariScreen.Recording.2024-04-30.at.2.56.24.AM.movMacOS: Chrome / SafariScreen.Recording.2024-04-30.at.2.51.42.AM.movMacOS: DesktopScreen.Recording.2024-04-30.at.2.54.30.AM.mov |
src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Although I'm not sure if using timeout
like this is allowed or not. @srikarparsi I would like to confirm this before merging 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chatted about this internally, we'll merge this so we can push forward the deploy and but perhaps we can keep the issue open to clean this up in a way that doesn't involve setTimeout
Haha yeah, I'm not sure if it's the best practice. We explored using InteractionManager.runAfterInteraction but it was a little too slow. I'm going to circle back on this with @tienifr and @rushatgabhane once they're online since they were the original authors to see if they have a better fix but I think since this fixes the deploy blocker for now, it should be fine. |
[CP Staging] Add 300ms timeout between RHP and Training Video (cherry picked from commit 4da18e0)
🚀 Deployed to production by https://github.com/francoisl in version: 1.4.67-7 🚀
|
1 similar comment
🚀 Deployed to production by https://github.com/francoisl in version: 1.4.67-7 🚀
|
Details
Fixed Issues
$ #41148
PROPOSAL:
Tests
Should be:
Shouldn't be:
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
N/A (Public room)
Android: mWeb Chrome
Screen.Recording.2024-04-29.at.5.12.16.PM.mov
iOS: Native
N/A (Public room)
iOS: mWeb Safari
Screen.Recording.2024-04-29.at.5.15.12.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2024-04-29.at.5.11.39.PM.mov
MacOS: Desktop
Screen.Recording.2024-04-29.at.5.17.23.PM.mov