-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix scan in progress isn't shown in room LHN last message when there is a scan in progress report preview #41187
Fix scan in progress isn't shown in room LHN last message when there is a scan in progress report preview #41187
Conversation
@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeScreen.Recording.2024-05-03.at.5.31.50.PM.moviOS: mWeb SafariScreen.Recording.2024-05-03.at.6.44.52.PM.movMacOS: Chrome / SafariScreen.Recording.2024-05-03.at.2.38.01.AM.mov |
Facing issues with ios simulator. I will try again in the morning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
This PR caused a deploy blocker here: #41753 |
@bernhardoj Are you online to create a quick fix? Otherwise we might need to revert the PR |
I'm gonna go ahead and manually revert this one. |
🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.71-6 🚀
|
Details
The last message depends on the last action of a report, but we filtered out any action that is a whisper, including the report preview that is still in scanning. This PR fix it.
Fixed Issues
$ #40557
PROPOSAL: #40557 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-04-29.at.19.04.37.mov
Android: mWeb Chrome
Screen.Recording.2024-04-29.at.10.58.27.mov
iOS: Native
Screen.Recording.2024-04-29.at.18.24.28.mov
iOS: mWeb Safari
Screen.Recording.2024-04-29.at.10.56.22.mov
MacOS: Chrome / Safari
Screen.Recording.2024-04-29.at.10.51.38.mov
MacOS: Desktop
Screen.Recording.2024-04-29.at.10.54.01.mov