Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary calls to updateLastRead #4078

Merged
merged 1 commit into from
Jul 15, 2021
Merged

Remove unnecessary calls to updateLastRead #4078

merged 1 commit into from
Jul 15, 2021

Conversation

iwiznia
Copy link
Contributor

@iwiznia iwiznia commented Jul 15, 2021

Details

Fixed Issues

$ #4077

Tests

On web:

  • Open a chat
  • Open the JS console and go to network
  • Send a message
  • Check only one call to Report_UpdateLastRead API command is done
  • Switch to a chat with no unread messages
  • Check no calls to Report_UpdateLastRead were done

QA Steps

Same as tests

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

@iwiznia iwiznia requested a review from a team July 15, 2021 15:06
@iwiznia iwiznia self-assigned this Jul 15, 2021
@MelvinBot MelvinBot requested review from Dal-Papa and removed request for a team July 15, 2021 15:07
@iwiznia iwiznia force-pushed the ionatan_unneceesary_lastread branch from d114089 to c59f5ab Compare July 15, 2021 15:16
@iwiznia iwiznia requested a review from a team as a code owner July 15, 2021 15:16
@MelvinBot MelvinBot requested review from luacmartins and removed request for a team July 15, 2021 15:16
luacmartins
luacmartins approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@luacmartins luacmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for this @iwiznia

@Dal-Papa Dal-Papa merged commit 107b77f into main Jul 15, 2021
@Dal-Papa Dal-Papa deleted the ionatan_unneceesary_lastread branch July 15, 2021 16:40
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Jul 15, 2021
Closed
95 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.78-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.79-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@marcaaron marcaaron mentioned this pull request Dec 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dal-Papa Dal-Papa Dal-Papa approved these changes

@luacmartins luacmartins luacmartins approved these changes

Assignees

@iwiznia iwiznia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iwiznia @OSBotify @Dal-Papa @luacmartins