-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA][TS migration] Remove almost all JS leftovers #40556
[No QA][TS migration] Remove almost all JS leftovers #40556
Conversation
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question, but LGTM !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Reviewer Checklist
Screenshots/VideosAndroid: NativeHaving build errors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving since the left comments are not blockers
We did not find an internal engineer to review this PR, trying to assign a random engineer to #29107 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
We did not find an internal engineer to review this PR, trying to assign a random engineer to #29107 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
We did not find an internal engineer to review this PR, trying to assign a random engineer to #29107 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
Automation not working correctly. Melvin is spawning engineers 😂 @chiragsalian can you please review this |
Added myself, i cant review today but i should be able to review tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, can you address the NAB and the error key and then I'll merge this.
Addressed remaining comment and merged with |
Just FYI that in case this PR doesn't get merged today and require more changes, I'm going to be OOO next week and will return on May 6th. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/chiragsalian in version: 1.4.67-0 🚀
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.4.67-7 🚀
|
1 similar comment
🚀 Deployed to production by https://github.com/francoisl in version: 1.4.67-7 🚀
|
Details
This PR removes almost all JS files that were leftovers of the TS migration. The following ones WON'T be migrated / removed:
(1) Entrypoint file (must be JS):
(2) Configuration files:
(3) Must stay in JS because TS version is not supported:
(4) Must be present on the codebase until the files of groups (5) and (6) are migrated / removed:
(5) Will be migrated / removed here:
(6) Will be removed as part of this refactor:
(7) Auto-generated files that must stay in JS version:
Fixed Issues
$ #39127
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop