-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NoQA] [CI/CD] Fix merging on E2E Performance Tests #40540
[NoQA] [CI/CD] Fix merging on E2E Performance Tests #40540
Conversation
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
Taking this one over since it's related to another PR I'm working |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
@staszekscp @danieldoglas Looking at the steps in this PR as mentioned in the QA steps, seem to be couldn't validate. Is this internal PR? |
🚀 Deployed to production by https://github.com/mountiny in version: 1.4.64-6 🚀
|
Details
This PR fixes an issue with multiple conflicts that appeared during merge on GitHub Actions while running performance tests. It has been mentioned on Slack
Fixed Issues
$ https://swmansion.slack.com/archives/C05LX9D6E07/p1713279039583959
$ #40544
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
N/AAndroid: mWeb Chrome
N/AiOS: Native
N/AiOS: mWeb Safari
N/AMacOS: Chrome / Safari
N/AMacOS: Desktop
N/A