Reusable and stylable money request amount input

[ZhenjaHorbach]

Details

Reusable and stylable money request amount input

Fixed Issues

$ #40382
PROPOSAL: #40382 (comment)

Tests

1. Open App
2. Click on FAB button
3. Choose Submit expence
4. Verify that Money Request Amount Input works correctly
5. After verifying open account settings and choose Profile
6. Click on Status, click on clear after, choose custom and click on Time
7. Verify that Time Picker works correctly

• Verify that no errors appear in the JS console

Offline tests

1. Open App
2. Click on FAB button
3. Choose Submit expence
4. Verify that Money Request Amount Input works correctly
5. After verifying open account settings and choose Profile
6. Click on Status, click on clear after, choose custom and click on Time
7. Verify that Time Picker works correctly

QA Steps

1. Open App
2. Click on FAB button
3. Choose Submit expence
4. Verify that Money Request Amount Input works correctly
5. After verifying open account settings and choose Profile
6. Click on Status, click on clear after, choose custom and click on Time
7. Verify that Time Picker works correctly

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android-web.mov

Android: mWeb Chrome

android.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web_0kuJlBMd.mp4

MacOS: Chrome / Safari

web_6rw0KoPH.mp4

MacOS: Desktop

desktop_MNbi88xu.mp4

[melvin-bot]

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

[melvin-bot]

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[hungvu193]

Please let's me know when this is ready. Thank you 😄

[ZhenjaHorbach]

Please let's me know when this is ready. Thank you 😄

I think the PR is already ready)
Maybe it could be made a little cleaner

But I need some sleep
I'll come back in a couple of hours and fill out the checklist and fix comments If they will)

[hungvu193]

Please let's me know when this is ready. Thank you 😄

I think the PR is already ready)

Maybe it could be made a little cleaner

But I need some sleep

I'll come back in a couple of hours and fill out the checklist and fix comments If they will)

Sure. Get some rests 😄 . I'll review in the mean time

[dubielzyk-expensify]

Would be good to get some screenshots too.

And just to confirm that we're not messing with the defaults of the input fields but rather adding a variation?

cc @youssef-lr @Expensify/design

[ZhenjaHorbach]

Please let's me know when this is ready. Thank you 😄

I think the PR is already ready)
Maybe it could be made a little cleaner
But I need some sleep
I'll come back in a couple of hours and fill out the checklist and fix comments If they will)

Sure. Get some rests 😄 . I'll review in the mean time

Hello )
I updated checklist
So PR is completely ready

[ZhenjaHorbach]

Would be good to get some screenshots too.

And just to confirm that we're not messing with the defaults of the input fields but rather adding a variation?

cc @youssef-lr @Expensify/design

@dubielzyk-expensify

Hello )
I made videos
The old inputs remain the same

[ZhenjaHorbach]

@youssef-lr

Hello)
I made some screenshots
To show how it will look in your PR

Plus I add prop for prefix and prefixContainer to make this component more flexible

[hungvu193]

Hello )

I update checklist

So PR is completely ready )

Cool. I'm AFK now but I'll review in the next couples of hour

[shawnborton]

Is it possible to right-align the text AND the prefixed character, while allowing it to be flexible enough to grow if needed?

[ZhenjaHorbach]

Is it possible to right-align the text AND the prefixed character, while allowing it to be flexible enough to grow if needed?

I'll test it now

[ZhenjaHorbach]

Is it possible to right-align the text AND the prefixed character, while allowing it to be flexible enough to grow if needed?

@shawnborton
Is it okay ?)

2024-04-18.13.20.18.mov

But in any case, I think at the moment we have a very flexible input
Because we can add styles for:
-input;
-inputContainer;
-prefix;
-prefixContainer

[shawnborton]

That does feel pretty good... can you show it using USD $, as I think that will be the mainline case? Thanks!

[ZhenjaHorbach]

That does feel pretty good... can you show it using USD $, as I think that will be the mainline case? Thanks!

here it is )

2024-04-18.14.00.13.mov

I used minimum width for examples
But if any case we can remove it

2024-04-18.14.00.53.mov

[shawnborton]

It feels like quite a big gap between the currency symbol and the amount here:

[ZhenjaHorbach]

It feels like quite a big gap between the currency symbol and the amount here:

What about this ?
I removed minWidth

[shawnborton]

Is there a way we can give the inputs a minWidth but also have the prefixed $ just sit right next to the amount? This is the mockup we created for this particular feature:

[ZhenjaHorbach]

Is there a way we can give the inputs a minWidth but also have the prefixed $ just sit right next to the amount? This is the mockup we created for this particular feature:

I think it's not a problem )

[shawnborton]

Let us know when this is ready for another design review!

[youssef-lr]

@shawnborton I have tested all inputs and everything looks good by default, for the split page style we can tackle those in my PR. We just need to ensure this PR is not affecting any default styles. I think let's go ahead and make another build!

[shawnborton]

Sounds good, will build now!

[youssef-lr]

Suggested change

	setNewAmount(frontendAmount);
	setCurrentAmount(frontendAmount);

We need to use setCurrentAmount here as used previously. We shouldn't be triggering onAmountChange from here because that's supposed to be only triggered via user input and via setNewAmount

[ZhenjaHorbach]

Done )

[hungvu193]

Nice catch on this one 👍, I should have caught it earlier 🤦

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
❌ FAILED ❌	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/40390/index.html
The QR code can't be generated, because the android build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/40390/NewExpensify.dmg	https://40390.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[youssef-lr]

@shawnborton let me know how the testing goes! I haven't found any issue in my testing so I think we're very close to merge this!

[dubielzyk-expensify]

Not sure if this was introduced in this PR but the button has no padding on the bottom. This doesn't happen in Prod/Staging on the status page, but it happens on Wallet on both (I'll file a bug separately):

[dubielzyk-expensify]

Input wise I couldn't find any issues

[hungvu193]

Not sure if this was introduced in this PR but the button has no padding on the bottom. This doesn't happen in Prod/Staging on the status page, but it happens on Wallet on both (I'll file a bug separately):

This is known issue and was reported earlier by @shawnborton in this slack convo:
https://expensify.slack.com/archives/C01GTK53T8Q/p1713455630242319

[youssef-lr]

Thanks for testing @dubielzyk-expensify! I'll wait to hear from @shawnborton before merging.

[shawnborton]

Gonna start testing this shortly, will report back!

[shawnborton]

Did some testing on iOS and couldn't seem to find anything, so I'd say this is all good on my end 👍

[youssef-lr]

Awesome, thanks everyone!!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.4.65-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.65-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[jayeshmangwani]

Coming from this issue #41762 , we are encountering an edge case on Android. When we select all the number and then add a number, the cursor is misplaced and appears at the start of the number. The reason for this is that on Android, when we select all the text and add a number, the selection update from onSelectionChange is triggered earlier than the manual selection update. As a result, the prevSelection already contains the new selection, leading to an incorrect selection calculation more context on the proposal #41762 (comment)