Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/pdf not showing for money request #40385

Merged
merged 7 commits into from
Apr 18, 2024
Merged

Fix/pdf not showing for money request #40385

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
177ccf4
Merge branch 'Expensify:main' into main
ishpaul777 Apr 15, 2024
f62c64e
Merge branch 'Expensify:main' into main
ishpaul777 Apr 16, 2024
be1b50f
Merge branch 'Expensify:main' into main
ishpaul777 Apr 17, 2024
719c1ed
Merge branch 'Expensify:main' into main
ishpaul777 Apr 17, 2024
1ca5520
fixes the issue
ishpaul777 Apr 17, 2024
06eb17d
Merge branch 'Expensify:main' into main
ishpaul777 Apr 18, 2024
2f05d22
Merge branch 'main' into fix/pdf-not-showing-for-money-request
ishpaul777 Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/MoneyTemporaryForRefactorRequestConfirmationList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -894,7 +894,7 @@ function MoneyTemporaryForRefactorRequestConfirmationList({
isLocalFile && Str.isPDF(receiptFilename) ? (
<PDFThumbnail
// eslint-disable-next-line @typescript-eslint/non-nullable-type-assertion-style
previewSourceURL={resolvedThumbnail as string}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this fix this? I would imagine that the thumbnail should be the source for <PDFThumbnail?

Copy link
Contributor Author

@ishpaul777 ishpaul777 Apr 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was like this before, thats exactly what made me believe thumbnail goes here lol

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we see why this is failing? or what is even in resolvedThumbnail?

Perhaps we just change it to this
resolvedThumbnail || resolvedReceiptImage || ''

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep i'll give this fair look again tomorrow, currently got afk

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we just change it to this
resolvedThumbnail || resolvedReceiptImage || ''

No need IMO, local files don't have thumbnail:

App/src/libs/ReceiptUtils.ts

Lines 47 to 49 in 3cf796c

if ((isReceiptImage || isReceiptPDF) && typeof path === 'string' && (path.startsWith('blob:') || path.startsWith('file:'))) {
return {image: path, isLocalFile: true, filename};
}

previewSourceURL={resolvedReceiptImage as string}
style={styles.moneyRequestImage}
// We don't support scaning password protected PDF receipt
enabled={!isAttachmentInvalid}
Expand Down
Loading