-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Implement filtering in task assignee list #40338
perf: Implement filtering in task assignee list #40338
Conversation
To be opened once #40235 gets merged - it's sharing the same logic for inviting a user as in the mentioned PR |
Updated with main |
Reviewer Checklist
Screenshots/VideosAndroid: Native40338_android_native.movAndroid: mWeb Chrome40338_android_mweb.moviOS: Native40338_ios_native.moviOS: mWeb Safari40338_ios_mweb.movMacOS: Chrome / Safari40338_web_chorme.movMacOS: Desktop40338_desktop.mov |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.0.13-0 🚀
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.13-4 🚀
|
Details
This PR implements filtering of options in Task assignee list, instead of relying on searchText property from options.
Fixed Issues
$ #46150
PROPOSAL:
Tests
main
branchadmin@expensify.com
Offline tests
n/a
QA Steps
admin@expensify.com
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
ANDROID.mov
Android: mWeb Chrome
ANDROID.WEB.mov
iOS: Native
IOS.mp4
iOS: mWeb Safari
IOS.WEB.mp4
MacOS: Chrome / Safari
WEB.mov
MacOS: Desktop
DESKTOP.mov