-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix Unsynchronized transition of left and right page when deleting workspace #40276
Conversation
@dubielzyk-expensify @cubuspl42 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This look good to me from a visual perspective. Thanks for fixing.
(cc @Expensify/design. Side note: This points out how jarring it is when you delete a workspace and it deletes it but doesn't really give a great confirmation. I wonder if a Toast component will ever be on our horizon.)
Hehe, fun fact.. we used to have growls in NewDot and killed them all. |
|
The code looks all right; I'll start filling the checklist today |
Yeah, separate topic I suppose but I think in these cases, some kind of confirmation is warranted. |
Reviewer Checklist
Screenshots/VideosAndroid: Nativefix-unsynchronized-transition-android-compressed.mp4Android: mWeb Chromefix-unsynchronized-transition-android-web-compressed.mp4iOS: Nativefix-unsynchronized-transition-ios-compressed.mp4iOS: mWeb Safarifix-unsynchronized-transition-ios-web-compressed.mp4MacOS: Chrome / Safarifix-unsynchronized-transition-web-converted.mp4MacOS: Desktop |
Hi! Can we add test steps for the two tab bug noted here (as well as any other situations that I might have missed)? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to production by https://github.com/mountiny in version: 1.4.64-6 🚀
|
Details
Fixed Issues
$ #38922
PROPOSAL: #38922 (comment)
Tests
Test 1
Desktop
Mobile
Test 2
Test 3
Offline tests
QA Steps
Test 1
Desktop
Mobile
Test 2
Test 3
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-04-16.at.16.24.01.mov
Android: mWeb Chrome
Screen.Recording.2024-04-16.at.16.27.02.mov
iOS: Native
Screen.Recording.2024-04-16.at.16.25.15.mov
iOS: mWeb Safari
Screen.Recording.2024-04-16.at.16.28.46.mov
MacOS: Chrome / Safari
Screen.Recording.2024-04-16.at.15.38.37.mov
MacOS: Desktop
Screen.Recording.2024-04-16.at.16.20.38.mov