Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/37095: Tag list show required #37388

Merged
merged 13 commits into from
Apr 5, 2024
Merged

Fix/37095: Tag list show required #37388

Changes from 5 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
3c62ad7
fix tag list show required
dukenv0307 Feb 28, 2024
bce6391
fix remove redundant code
dukenv0307 Feb 28, 2024
cd91a49
fix remove redundant logic
dukenv0307 Feb 28, 2024
fc5bebc
fix merge main
dukenv0307 Mar 3, 2024
8cd38b8
fix single tag case
dukenv0307 Mar 3, 2024
cde6014
fix lint
dukenv0307 Mar 3, 2024
247827b
fix create isTagRequired variable
dukenv0307 Mar 3, 2024
7d3a9c6
fix remove isTag
dukenv0307 Mar 3, 2024
f0c955b
fix add canUseViolation
dukenv0307 Mar 5, 2024
5ef00a4
Merge branch 'main' into fix/37095-disabled-tags-are-showing-as-required
dukenv0307 Mar 5, 2024
d3b88b5
fix lint
dukenv0307 Mar 6, 2024
7b00537
fix merge main
dukenv0307 Apr 1, 2024
025be6b
fix conflict
dukenv0307 Apr 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/components/MoneyTemporaryForRefactorRequestConfirmationList.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@
const isMerchantRequired = isPolicyExpenseChat && !isScanRequest && shouldShowMerchant;

const isCategoryRequired = canUseViolations && lodashGet(policy, 'requiresCategory', false);
const isTagRequired = canUseViolations && lodashGet(policy, 'requiresTag', false);

Check failure on line 313 in src/components/MoneyTemporaryForRefactorRequestConfirmationList.js

View workflow job for this annotation

GitHub Actions / Run ESLint 

'isTagRequired' is assigned a value but never used

useEffect(() => {
if ((!isMerchantRequired && isMerchantEmpty) || !merchantError) {
Expand Down Expand Up @@ -763,7 +763,7 @@
shouldShow: shouldShowCategories,
isSupplementary: !isCategoryRequired,
},
..._.map(policyTagLists, ({name}, index) => ({
..._.map(policyTagLists, ({name, required}, index) => ({
item: (
<MenuItemWithTopDescription
key={name}
Expand All @@ -779,11 +779,11 @@
style={[styles.moneyRequestMenuItem]}
disabled={didConfirm}
interactive={!isReadOnly}
rightLabel={isTagRequired ? translate('common.required') : ''}
rightLabel={required ? translate('common.required') : ''}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use required field in both single tag and mulitple levels tags case based on comment

/>
),
shouldShow: shouldShowTags,
isSupplementary: !isTagRequired,
isSupplementary: !required,
})),
{
item: (
Expand Down
Loading