Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS migration] Migrate MoneyTemporaryForRefactorRequestConfirmationList.js component to TypeScript #37181

Merged
merged 46 commits into from
Apr 11, 2024
Merged
Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
3df8de2
Convert to typescript
allgandalf Feb 25, 2024
7403c61
Merge branch 'main' into issue-36130
allgandalf Feb 25, 2024
a8e69fd
Fix RBR error
allgandalf Feb 26, 2024
4523f0b
Merge branch 'main' into issue-36130
allgandalf Feb 26, 2024
5729939
Migrate to typescript
allgandalf Feb 26, 2024
1029bec
Working with onyx
allgandalf Feb 26, 2024
66a4e31
fix props
allgandalf Feb 26, 2024
ee443d6
Merge branch 'main' into issue-36130
allgandalf Feb 28, 2024
aae1a41
Migrate to typescript
allgandalf Feb 28, 2024
348d5ed
Merge branch 'main' into issue-36130
allgandalf Mar 6, 2024
2a59f2b
migrate to typescript
allgandalf Mar 6, 2024
4e06aac
Migrate to typescript
allgandalf Mar 6, 2024
4b2e38e
Migrate to typescript
allgandalf Mar 6, 2024
e7dd703
Merge branch 'main' into issue-36130
allgandalf Mar 6, 2024
352b991
Lint fix
allgandalf Mar 6, 2024
27a1f9e
Lint fix
allgandalf Mar 6, 2024
9248cfd
Merge branch 'main' into issue-36130
allgandalf Mar 13, 2024
9076b8c
prettier
allgandalf Mar 13, 2024
771d177
Migrate to typescript
allgandalf Mar 13, 2024
b761e9f
Migrate to typescript
allgandalf Mar 13, 2024
06bda01
Merge branch 'main' into issue-36130
allgandalf Mar 17, 2024
17b2361
Apply suggestions from code review
allgandalf Mar 17, 2024
d7f7da5
Merge branch 'main' into issue-36130
allgandalf Mar 20, 2024
3cd8027
Fix null assertions
allgandalf Mar 20, 2024
913fedc
Resolve merge conflict and introduce isSelfDM prop
allgandalf Mar 21, 2024
f93c3d6
introduce isSelfDM prop
allgandalf Mar 21, 2024
a2dcc02
Resolve Merge Conflict
allgandalf Mar 22, 2024
c57e69f
Fix Lint
allgandalf Mar 22, 2024
3cae551
Resolve Merge Conflict
allgandalf Mar 27, 2024
a1420c4
fix lint
allgandalf Mar 27, 2024
9f73b2a
introduce isSelfDM in ONyx
allgandalf Mar 27, 2024
e72fc34
Resolve merge conflict
allgandalf Apr 3, 2024
164c821
Merge branch 'Expensify:main' into issue-36130
allgandalf Apr 4, 2024
ea38fe8
Resolve merge conflict
allgandalf Apr 5, 2024
ee5168a
Resolve merge conflict
allgandalf Apr 9, 2024
79aca73
Fix taxRatetitle
allgandalf Apr 9, 2024
7a215e1
Resolve merge conflict
allgandalf Apr 10, 2024
0575d3e
resolve merge conflict market
allgandalf Apr 10, 2024
8af855a
Merge branch 'Expensify:main' into issue-36130
allgandalf Apr 10, 2024
ee2cf51
Merge branch 'Expensify:main' into issue-36130
allgandalf Apr 11, 2024
8371c94
Merge branch 'Expensify:main' into issue-36130
allgandalf Apr 11, 2024
7941b66
Fix unrelated typefails
allgandalf Apr 11, 2024
b134300
Fix unrelated typefails
allgandalf Apr 11, 2024
130ad9a
Fix unrelated typefails
allgandalf Apr 11, 2024
d7f5a92
Merge branch 'Expensify:main' into issue-36130
allgandalf Apr 11, 2024
ae5242f
Fix unrelated typefails
allgandalf Apr 11, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/ButtonWithDropdownMenu/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ type WorkspaceMemberBulkActionType = DeepValueOf<typeof CONST.POLICY.MEMBERS_BUL
type DropdownOption<TValueType> = {
value: TValueType;
text: string;
icon: IconAsset;
icon?: IconAsset;
iconWidth?: number;
iconHeight?: number;
iconDescription?: string;
Expand Down Expand Up @@ -56,7 +56,7 @@ type ButtonWithDropdownMenuProps<TValueType> = {
anchorAlignment?: AnchorAlignment;

/* ref for the button */
buttonRef: RefObject<View>;
buttonRef?: RefObject<View>;

/** The priority to assign the enter key event listener to buttons. 0 is the highest priority. */
enterKeyEventListenerPriority?: number;
Expand Down
Loading
Loading