-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TS migration] Migrate 'SettingsPreferences' page to TypeScript #36523
[TS migration] Migrate 'SettingsPreferences' page to TypeScript #36523
Conversation
…rences-to-typescript
…rences-to-typescript
…rences-to-typescript
…rences-to-typescript # Conflicts: # src/pages/settings/Preferences/LanguagePage.tsx
…rences-to-typescript
@fabioh8010 @rezkiy37 feedback addressed, let me know if there's anything else! 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, overall looks good!
FYI @pac-guerreiro is OOO this week and will return on March 11th. |
…rences-to-typescript # Conflicts: # src/pages/settings/Preferences/PreferencesPage.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and tested well
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/deetergp in version: 1.4.53-0 🚀
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 1.4.53-2 🚀
|
const defaultProps = { | ||
priorityMode: CONST.PRIORITY_MODE.DEFAULT, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change has caused a regression in #40789 , for newly created accounts the priorityMode
is not set.
Details
Fixed Issues
$#25209
PROPOSAL: N/A
Tests
Settings > Preferences
and verify that everything is okayPriority mode
and verify that everything is okay, then go back toPreferences
Language
and verify that everything is okay, then go back toPreferences
Theme
and verify that everything is okay, then go back toPreferences
Offline tests
Same as tests.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop