Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] Add GTM call as a file #36471

Merged
merged 8 commits into from
Feb 14, 2024
Merged

[No QA] Add GTM call as a file #36471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
aad46a3
adding gtm file
danieldoglas Feb 14, 2024
29476e0
using reference for file
danieldoglas Feb 14, 2024
857fdfa
adding copy file on build for web
danieldoglas Feb 14, 2024
0833ce9
linter
danieldoglas Feb 14, 2024
71922fc
linter
danieldoglas Feb 14, 2024
5d39a9e
prettier
danieldoglas Feb 14, 2024
8a4f5b7
Merge branch 'main' into dsilva_gtmAsAFile
danieldoglas Feb 14, 2024
98278b3
Merge branch 'main' into dsilva_gtmAsAFile
danieldoglas Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config/webpack/webpack.common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ const webpackConfig = ({envFile = '.env', platform = 'web'}) => ({
{from: 'web/apple-touch-icon.png'},
{from: 'assets/images/expensify-app-icon.svg'},
{from: 'web/manifest.json'},
{from: 'web/gtm.js'},
{from: 'assets/css', to: 'css'},
{from: 'assets/fonts/web', to: 'fonts'},
{from: 'assets/sounds', to: 'sounds'},
Expand Down
11 changes: 11 additions & 0 deletions web/gtm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
/* eslint-disable no-param-reassign, prefer-template */
(function (w, d, s, l, i) {
w[l] = w[l] || [];
w[l].push({'gtm.start': new Date().getTime(), event: 'gtm.js'});
const f = d.getElementsByTagName(s)[0];
const j = d.createElement(s);
const dl = l !== 'dataLayer' ? '&l=' + l : '';
j.async = true;
j.src = 'https://www.googletagmanager.com/gtm.js?id=' + i + dl;
f.parentNode.insertBefore(j, f);
})(window, document, 'script', 'dataLayer', 'GTM-N4M3FLJZ');
4 changes: 2 additions & 2 deletions web/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,8 @@
<!-- polyfill.io is only needed on Web to support older browsers. It should not be loaded for desktop -->
<script src="https://polyfill.io/v3/polyfill.min.js?features=default%2CResizeObserver&flags=gated"></script>
<% if (htmlWebpackPlugin.options.isProduction) { %>
<!-- Google Tag Manager - This was provided by our partner marketing agency -->
<script async="" src="https://www.googletagmanager.com/gtm.js?id=GTM-N4M3FLJZ"></script>
<!-- Google Tag Manager -->
<script async="" src="gtm.js"></script>
<!-- End Google Tag Manager -->
<% } %>
<% } %>
Expand Down
Loading