-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistent system paid message #36298
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -354,7 +354,15 @@ const ContextMenuActions: ContextMenuAction[] = [ | |
const modifyExpenseMessage = ModifiedExpenseMessage.getForReportAction(reportID, reportAction); | ||
Clipboard.setString(modifyExpenseMessage); | ||
} else if (ReportActionsUtils.isMoneyRequestAction(reportAction)) { | ||
const displayMessage = ReportUtils.getIOUReportActionDisplayMessage(reportAction); | ||
const displayMessage = ReportUtils.getReportPreviewMessage( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I see there are many differences between Screen.Recording.2024-02-15.at.11.10.56.movThere was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @DylanDylann For this case I think we should ask internal team to confirm the expected for this case again, because it's displayed There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @dukenv0307 Also remove getIOUReportActionDisplayMessage function There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @DylanDylann I updated. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What happened here? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's wrong here? I saw that all cases in |
||
ReportUtils.getReport(ReportUtils.getOriginalReportID(reportID, reportAction)), | ||
reportAction, | ||
false, | ||
false, | ||
null, | ||
false, | ||
true, | ||
); | ||
Clipboard.setString(displayMessage); | ||
} else if (ReportActionsUtils.isCreatedTaskReportAction(reportAction)) { | ||
const taskPreviewMessage = TaskUtils.getTaskCreatedMessage(reportAction); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this empty line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dukenv0307 Bump