Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP Staging] Fix bug with Payment option reverts back to 'Pay with Expensify' #36115

Merged
merged 3 commits into from
Feb 8, 2024
Merged

[CP Staging] Fix bug with Payment option reverts back to 'Pay with Expensify' #36115

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b24edbe
Fix bug with Payment option reverts back
ZhenjaHorbach Feb 8, 2024
0789c2e
Fix lint issue
ZhenjaHorbach Feb 8, 2024
dd050fc
Fix comment
ZhenjaHorbach Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/SettlementButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import sortBy from 'lodash/sortBy';
import React, {useEffect, useMemo} from 'react';
import type {GestureResponderEvent, StyleProp, ViewStyle} from 'react-native';
import type {OnyxEntry} from 'react-native-onyx';
Expand Down Expand Up @@ -182,7 +183,7 @@ function SettlementButton({

// Put the preferred payment method to the front of the array, so it's shown as default
if (paymentMethod) {
return buttonOptions.sort((method) => (method.value === paymentMethod ? 0 : 1));
return sortBy(buttonOptions, (method) => (method.value === paymentMethod ? 0 : 1));
Julesssss marked this conversation as resolved.
Show resolved Hide resolved
}
return buttonOptions;
// We don't want to reorder the options when the preferred payment method changes while the button is still visible
Expand Down
Loading