-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] Fix Apple and Google SSO when login in from public room with mentions in it #36041
Conversation
@marcaaron Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/Videos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 🙇
Ignoring perf tests |
@Julesssss looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
This resolves a fire, so I ignored the performance check |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
[CP Staging] Fix Apple and Google SSO when login in from public room with mentions in it (cherry picked from commit 79540ce)
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.4.38-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
Parent issue here btw: https://github.com/Expensify/Expensify/issues/367462 |
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.4.38-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.38-6 🚀
|
Details
When signing using Apple SSO as anonymous user from public room in web, the app crashed with following stacktrace:
The error comes from expensify-common on this line, where the str seems to be undefined, that is passed from the extractEmailDomain here and that is called from the App here.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/367462
https://expensify.slack.com/archives/C06HN74HKMG/p1707321835134969
Tests
Offline tests
n/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Screen.Recording.2024-02-07.at.16.40.37.mp4
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop