Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP Staging] Fix a type in a prop name #35622

Merged
merged 3 commits into from
Feb 5, 2024
Merged

[CP Staging] Fix a type in a prop name #35622

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db641ff
fix typo
Feb 2, 2024
137f77a
chore: change prop name
Feb 5, 2024
dc2d41b
chore: change back the prop name
Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/components/FeatureList.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ const propTypes = {
ctaAccessibilityLabel: PropTypes.string,

/** Action to call on cta button press */
onCTAPress: PropTypes.func,
onCtaPress: PropTypes.func,

/** A list of menuItems representing the feature list. */
menuItems: PropTypes.arrayOf(PropTypes.shape({...menuItemPropTypes, translationKey: PropTypes.string})).isRequired,
Expand All @@ -48,13 +48,13 @@ const defaultProps = {
ctaText: '',
ctaAccessibilityLabel: '',
subtitle: '',
onCTAPress: () => {},
onCtaPress: () => {},
illustration: null,
illustrationBackgroundColor: '',
illustrationStyle: [],
};

function FeatureList({title, subtitle, ctaText, ctaAccessibilityLabel, onCTAPress, menuItems, illustration, illustrationStyle, illustrationBackgroundColor}) {
function FeatureList({title, subtitle, ctaText, ctaAccessibilityLabel, onCtaPress, menuItems, illustration, illustrationStyle, illustrationBackgroundColor}) {
const styles = useThemeStyles();
const {translate} = useLocalize();

Expand Down Expand Up @@ -91,7 +91,7 @@ function FeatureList({title, subtitle, ctaText, ctaAccessibilityLabel, onCTAPres
</View>
<Button
text={ctaText}
onPress={onCTAPress}
onPress={onCtaPress}
accessibilityLabel={ctaAccessibilityLabel}
style={[styles.w100]}
success
Expand Down
Loading