Add GPS coordinates to smartscanned images #35428

tgolen · 2024-01-30T18:45:46Z

Held on https://github.com/Expensify/Web-Expensify/pull/40634 which implements the new parameters

Details

When requesting money using the "Scan" method, the user's location information will be requested and added to the payload as part of the confirmation step.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/362628

Tests

Request money from someone using the scan feature
If prompted to allow access to your location, grant the permission
Verify in the network requests, you see the gpsPoints as part of the payload

Verify that no errors appear in the JS console

Offline tests

None, this requires network requests to be made.

QA Steps

Sign into NewDot
Request money from someone by scanning a receipt that has an obscured currency (use a real receipt but use a marker to remove any currency symbols)
Wait for the receipt to finish smartscanning
Verify that the currency of the receipt matches the default currency of your current location (best to do this in a non-USD location to prove it's working)

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

NA

dylanexpensify · 2024-02-01T21:13:00Z

Looks like the blocking PR got deployed to prod!

melvin-bot · 2024-02-02T15:54:45Z

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/pages/iou/request/step/IOURequestStepConfirmation.js

Co-authored-by: Ionatan Wiznia <ionatan@expensify.com>

c3024 · 2024-02-03T05:11:00Z

Sometimes, the right hand panel does not get dismissed immediately after clicking Request potentially causing a user to click Request button multiple times making multiple requests.

gpsChrome.mp4

tgolen · 2024-02-05T18:47:21Z

@c3024 thanks for pointing that out. I'll get that fixed in the next couple of hours (right after lunch).

tgolen · 2024-02-05T20:15:13Z

@c3024 I have updated the branch

iwiznia · 2024-02-05T20:44:15Z

src/pages/iou/request/step/IOURequestStepConfirmation.js

@@ -228,6 +229,13 @@ function IOURequestStepConfirmation({
        (selectedParticipants) => {
            const trimmedComment = lodashGet(transaction, 'comment.comment', '').trim();

+            // Don't let the form be submitted multiple times while the navigator is waiting to take the user to a different page
+            if (formHasBeenSubmitted) {


Shouldn't we be disabling the button?

The button is about 5-6 nested components deep and would need a new prop. This problem isn't unique to this form (but getting the user's location doesn't help since it adds a little delay). so I didn't feel that adding a new disabled prop, and drilling it down, just for this form would be very valuable.

dylanexpensify · 2024-02-06T07:41:50Z

@c3024 please complete checklist when ready!!

c3024 · 2024-02-06T08:18:41Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

gpsChrome.mp4

MacOS: Desktop

c3024

Tests well

melvin-bot · 2024-02-06T08:26:13Z

@johnmlee101 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2024-02-06T08:26:16Z

🎯 @c3024, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #35879.

tgolen · 2024-02-06T16:13:25Z

I'll go ahead and merge this since an internal engineer has already approved it.

OSBotify · 2024-02-06T16:17:58Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-07T10:09:33Z

🚀 Deployed to staging by https://github.com/tgolen in version: 1.4.38-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-07T10:26:06Z

🚀 Deployed to staging by https://github.com/tgolen in version: 1.4.38-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-08T18:21:24Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.38-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Add GPS coordinates to smartscanned images

e9c7742

tgolen self-assigned this Jan 30, 2024

Add error logging

141cf89

tgolen changed the title ~~[HOLD Web-Expensify/pull/40634] Add GPS coordinates to smartscanned images~~ Add GPS coordinates to smartscanned images Feb 2, 2024

tgolen marked this pull request as ready for review February 2, 2024 15:54

tgolen requested a review from a team as a code owner February 2, 2024 15:54

melvin-bot bot removed the request for review from a team February 2, 2024 15:54

melvin-bot bot requested a review from c3024 February 2, 2024 15:54

iwiznia previously approved these changes Feb 2, 2024

View reviewed changes

src/pages/iou/request/step/IOURequestStepConfirmation.js Outdated Show resolved Hide resolved

tgolen dismissed iwiznia’s stale review via ae1665d February 2, 2024 16:39

Update src/pages/iou/request/step/IOURequestStepConfirmation.js

ae1665d

Co-authored-by: Ionatan Wiznia <ionatan@expensify.com>

iwiznia previously approved these changes Feb 2, 2024

View reviewed changes

Merge branch 'main' into tgolen-implement-smartscangps

f347d8f

Prevent form from being submitted multiple times

c34932c

tgolen dismissed iwiznia’s stale review via c34932c February 5, 2024 20:14

tgolen requested a review from iwiznia February 5, 2024 20:15

iwiznia reviewed Feb 5, 2024

View reviewed changes

tgolen added 4 commits February 5, 2024 13:50

Merge branch 'main' into tgolen-implement-smartscangps

44bfa61

Add GPS points to the types

df02d87

Use a ref instead of a variable.

77be411

Style

e83c24a

iwiznia approved these changes Feb 5, 2024

View reviewed changes

c3024 approved these changes Feb 6, 2024

View reviewed changes

melvin-bot bot requested a review from johnmlee101 February 6, 2024 08:26

melvin-bot bot mentioned this pull request Feb 6, 2024

Payment issue for E/App PR#35428 #35879

Closed

tgolen merged commit 67a46f5 into main Feb 6, 2024
15 of 16 checks passed

tgolen deleted the tgolen-implement-smartscangps branch February 6, 2024 16:13

github-actions bot mentioned this pull request Feb 7, 2024

Deploy Checklist: New Expensify 2024-02-07 #35983

Closed

49 tasks

AndrewGable mentioned this pull request Feb 7, 2024

[HOLD for payment 2024-02-20] Request - App asks for location access when creating Manual request with receipt #36037

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add GPS coordinates to smartscanned images #35428

Add GPS coordinates to smartscanned images #35428

tgolen commented Jan 30, 2024 •

edited

Loading

dylanexpensify commented Feb 1, 2024

melvin-bot bot commented Feb 2, 2024

c3024 commented Feb 3, 2024

tgolen commented Feb 5, 2024

tgolen commented Feb 5, 2024

iwiznia Feb 5, 2024

tgolen Feb 5, 2024

dylanexpensify commented Feb 6, 2024

c3024 commented Feb 6, 2024 •

edited

Loading

c3024 left a comment

melvin-bot bot commented Feb 6, 2024

melvin-bot bot commented Feb 6, 2024

tgolen commented Feb 6, 2024

OSBotify commented Feb 6, 2024

OSBotify commented Feb 7, 2024

OSBotify commented Feb 7, 2024

OSBotify commented Feb 8, 2024

Add GPS coordinates to smartscanned images #35428

Add GPS coordinates to smartscanned images #35428

Conversation

tgolen commented Jan 30, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

dylanexpensify commented Feb 1, 2024

melvin-bot bot commented Feb 2, 2024

c3024 commented Feb 3, 2024

tgolen commented Feb 5, 2024

tgolen commented Feb 5, 2024

iwiznia Feb 5, 2024

Choose a reason for hiding this comment

tgolen Feb 5, 2024

Choose a reason for hiding this comment

dylanexpensify commented Feb 6, 2024

c3024 commented Feb 6, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

c3024 left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Feb 6, 2024

melvin-bot bot commented Feb 6, 2024

tgolen commented Feb 6, 2024

OSBotify commented Feb 6, 2024

OSBotify commented Feb 7, 2024

OSBotify commented Feb 7, 2024

OSBotify commented Feb 8, 2024

tgolen commented Jan 30, 2024 •

edited

Loading

c3024 commented Feb 6, 2024 •

edited

Loading