-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/34610: Remove NewDistanceRequestPage and EditRequestDistancePage #35302
Conversation
@cubuspl42 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Linter complaining |
Once you fix the lints, would you please very briefly sum up what changed since the un-holding? |
@cubuspl42 Currently, we use |
Signed-off-by: DylanDylann <dylandylan9112@gmail.com>
@cubuspl42 The PR is ready for review |
This doesn't apply to Native. Please make the testing steps cover all platforms. If some platforms are meant to be unaffected, describe tests that verify that. |
Also, I assume you mean that the "browser's URL should update to", "route display(s)" is not a common way to phrase that. |
This change is so straightforward. Verifying the route on the web is enough. In other platforms, ensuring the distance request works well is enough |
I think it is a good way to verify this PR. we need to make sure the new route is applied instead of the old one |
I'm not discussing the essence of what you wrote. I'm just leaving an organizational comment. Unless tests are cross platform, mention it. Per single step, or per set of steps. So if you want to comment on things like URL bar or any Web-specific behavior, say "On the Web, expect that the URL is...". If a whole set of steps is for a single platform only, you can write: On Native:
On Web:
|
@cubuspl42 Thanks for your reminder Updated:
|
I think there's no reason to skip QA; let's move Tests to QA Steps and write "Same as QA Steps" in "Tests" |
I'm not sure I completely understand you. Do you mean that the verification you mention is taking a look at the browser's URL bar, or not? |
I'm observing some exceptions, I'm not sure what's the root cause. Might be something on I tested after merging in remove-NewDistanceRequestPage-ios-compressed.mp4 |
Yeah, the browser's URL bar. It is my mean |
@cubuspl42 Please ping me if there is any problem. We should speed up this PR |
@DylanDylann I had problems testing this yesterday (like I mentioned), but I'm trying again. |
@cubuspl42 I have never seen this error while testing. Please log out and log in again to reset ONYX. |
Reviewer Checklist
Screenshots/VideosAndroid: Nativeremove-NewDistanceRequestPage-android-compressed.mp4Android: mWeb Chromeremove-NewDistanceRequestPage-android-web-compressed.mp4iOS: Nativeremove-NewDistanceRequestPage-ios-compressed.mp4iOS: mWeb Safariremove-NewDistanceRequestPage-ios-web-compressed.mp4MacOS: Chrome / Safariremove-NewDistanceRequestPage-web-converted.mp4MacOS: Desktop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/cristipaval in version: 1.4.56-0 🚀
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.56-8 🚀
|
Details
Use IOURequestStepDistance instead of NewDistanceRequestPage and EditRequestDistancePage
Fixed Issues
$ #34610
PROPOSAL: #34610 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-03-20.at.11.12.37.mov
Android: mWeb Chrome
Screen.Recording.2024-03-20.at.10.52.25.mov
iOS: Native
Screen.Recording.2024-03-20.at.11.09.39.mov
iOS: mWeb Safari
Screen.Recording.2024-03-20.at.10.51.33.mov
MacOS: Chrome / Safari
Screen.Recording.2024-03-20.at.10.46.08.mp4
MacOS: Desktop
Screen.Recording.2024-03-20.at.10.53.37.mov