Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use lazy loading for the IOU Report previews #33981

Merged
merged 8 commits into from
Jan 16, 2024
Merged

fix: use lazy loading for the IOU Report previews #33981

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d0c910e
Use report.lastMessageText as the all-case fallback for getLastMessag…
paultsimura Jan 2, 2024
016a24c
Merge branch 'main' into fix/32658-lazy-lhn-subtext
paultsimura Jan 4, 2024
1d1bf14
Update usage of getDisplayNameOrDefault
paultsimura Jan 4, 2024
411ecdc
Merge branch 'main' into fix/32658-lazy-lhn-subtext
paultsimura Jan 5, 2024
1bb63ab
Merge branch 'main' into fix/32658-lazy-lhn-subtext
paultsimura Jan 11, 2024
06da36a
Merge branch 'main' into fix/32658-lazy-lhn-subtext
paultsimura Jan 11, 2024
8e1d451
Use report.lastMessageText as the all-case fallback
paultsimura Jan 11, 2024
9cbd2c6
Merge branch 'main' into fix/32658-lazy-lhn-subtext
paultsimura Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/libs/OptionsListUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,10 +436,9 @@ function getLastMessageTextForReport(report) {
lastMessageTextFromReport = lodashGet(lastReportAction, 'message[0].text', '');
} else if (ReportActionUtils.isCreatedTaskReportAction(lastReportAction)) {
lastMessageTextFromReport = TaskUtils.getTaskCreatedMessage(lastReportAction);
} else {
lastMessageTextFromReport = report ? report.lastMessageText || '' : '';
}
return lastMessageTextFromReport;

return lastMessageTextFromReport || lodashGet(report, 'lastMessageText', '');
}

/**
Expand Down
Loading