-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TS migration] Migrate 'ReportAttachments' page to TypeScript #33840
[TS migration] Migrate 'ReportAttachments' page to TypeScript #33840
Conversation
source: PropTypes.string.isRequired, | ||
}).isRequired, | ||
}).isRequired, | ||
type File = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just wonder if this type shouldn't be global
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are right , I remember that in other Attachments files we should use the same type , I will move it to other place , thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a type for File defined globally, but it has a different structure:
interface File {
source: string;
uri: string;
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
source: PropTypes.string.isRequired, | ||
}).isRequired, | ||
}).isRequired, | ||
type File = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a type for File defined globally, but it has a different structure:
interface File {
source: string;
uri: string;
}
@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
const report = ReportUtils.getReport(reportID); | ||
|
||
// In native the imported images sources are of type number. Ref: https://reactnative.dev/docs/image#imagesource | ||
const decodedSource = decodeURI(_.get(props, ['route', 'params', 'source'])); | ||
const decodedSource = decodeURI(route.params.source); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't route.params
nullish? This is inconsistent with above line - const reportID = route.params?.reportID;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actaully its not nullish , I removed optional chaining from const reportID = route.params?.reportID;
…s-migration/ReportAttachments/page
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid.movAndroid: mWeb Chromemchrome.moviOS: Nativeios.moviOS: mWeb Safarimsafari.movMacOS: Chrome / Safariweb.movMacOS: Desktopdesktop.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
We did not find an internal engineer to review this PR, trying to assign a random engineer to #31986 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.26-2 🚀
|
Details
Fixed Issues
$ #31986
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mp4
Android: mWeb Chrome
mweb-chrom.mp4
iOS: Native
ios.mp4
iOS: mWeb Safari
mweb-safari.mp4
MacOS: Chrome / Safari
web.mp4
MacOS: Desktop
desktop.mp4