Fixed picker scroll glitch #3384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HorusGoul
approved these changes
Jun 7, 2021
11 tasks
|
🚀 Deployed to staging in version: 1.0.63-1🚀
|
|
🚀 Deployed to production in version: 1.0.64-0🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
A detailed explanation of the issue & this PR's solution, can be found here #3023 (comment)
Fixed Issues
Fixes #3023
Tests
QA Steps
Open E.cash.
Open any chat.
Open the Emoji picker from the composer.
Scroll to the end of the Emoji List.
when the end is reached, there should not be a scroll glitch like
Bug5076512_mWeb_flags.mp4
Tested On
Screenshots
Web
Mobile Web
scroll.bug.mp4
Desktop
iOS
Android