-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TS migration] Migrate 'LogInWithShortLivedAuthToken' page to TypeScript #33062
[TS migration] Migrate 'LogInWithShortLivedAuthToken' page to TypeScript #33062
Conversation
…tlivedauthtokenpage-to-typescript # Conflicts: # src/pages/LogInWithShortLivedAuthTokenPage.tsx
205ce77
to
1ae14f4
Compare
@fabioh8010 @kubabutkiewicz All feedback addressed! 😄 |
Added tests and screenshots! 😄 |
1ae14f4
to
7a8e43e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😄
…tlivedauthtokenpage-to-typescript
@aimane-chnaif will do a C+ review here |
…tlivedauthtokenpage-to-typescript
Code looks good. Please resolve conflict. Syncing main will also fix reassure performance tests failing |
…tlivedauthtokenpage-to-typescript # Conflicts: # src/libs/Navigation/types.ts
Conflicts resolved! 😄 |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / Safariweb.movMacOS: Desktop |
@@ -94,7 +72,7 @@ function LogInWithShortLivedAuthTokenPage(props) { | |||
</View> | |||
<Text style={[styles.textHeadline, styles.textXXLarge]}>{translate('deeplinkWrapper.launching')}</Text> | |||
<View style={styles.mt2}> | |||
<Text style={[styles.fontSizeNormal, styles.textAlignCenter]}> | |||
<Text style={styles.textAlignCenter}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<Text style={styles.textAlignCenter}> | |
<Text style={[styles.textNormal, styles.textAlignCenter]}> |
NAB since fontSize
is variables.fontSizeNormal
as default
🎯 @aimane-chnaif, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #34481. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.26-2 🚀
|
Details
Fixed Issues
$#25176
PROPOSAL: N/A
Tests
Scenario 1 - Invalid Token
web
, navigate to https://dev.new.expensify.com:8082/transition and observe the "Launching Expensify - Your session has expired. Please sign in again." messageScenario 2 - Redirect user when exitTo param is provided
web
, navigate to https://dev.new.expensify.com:8082/transition?exitTo=/ and notice that you are redirected to the sign in page, in case you aren't signed in, otherwise you'll be redirected to the home screen.Offline tests
N/A
QA Steps
Scenario 1 - Invalid Token
web
, navigate to https://new.expensify.com/transition and observe the "Launching Expensify - Your session has expired. Please sign in again." messageScenario 2 - Redirect user when exitTo param is provided
web
, navigate to https://new.expensify.com/transition?exitTo=/ and notice that you are redirected to the sign in page, in case you aren't signed in, otherwise you'll be redirected to the home screen.PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
MacOS: Chrome / Safari