Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: HTML to Markdown parser integration #3229

Merged
merged 10 commits into from
Jul 1, 2021
Merged

feat: HTML to Markdown parser integration #3229

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ee3724c
feat: HTML to Markdown parser integration
pranshuchittora May 29, 2021
5c3f7a6
feat: Updated package json
pranshuchittora Jun 22, 2021
c0f3fc3
Merge remote-tracking branch 'origin/main' into pranshuchittora/feat/…
pranshuchittora Jun 22, 2021
5107f55
feat: Migration to another component
pranshuchittora Jun 23, 2021
e66c1a7
fix: Minor fixes
pranshuchittora Jun 23, 2021
44c75fa
feat: New approach
pranshuchittora Jun 24, 2021
1906234
fix: Removed unwanted props
pranshuchittora Jun 24, 2021
5e610a8
fix: Minor changes to the object keys
pranshuchittora Jun 25, 2021
69f191a
feat: Updated method doc
pranshuchittora Jun 27, 2021
ab6145f
feat: Updated method doc
pranshuchittora Jun 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 30 additions & 5 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"electron-log": "^4.3.5",
"electron-serve": "^1.0.0",
"electron-updater": "^4.3.4",
"expensify-common": "^1.0.1",
"expensify-common": "git://github.com/Expensify/expensify-common.git#c3465bf615390a2844087ec7f2343b0607ea484c",
"file-loader": "^6.0.0",
"html-entities": "^1.3.1",
"lodash": "4.17.21",
Expand Down
4 changes: 3 additions & 1 deletion src/pages/home/report/ReportActionContextMenu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import React from 'react';
import {View} from 'react-native';
import PropTypes from 'prop-types';
import lodashGet from 'lodash/get';
import ExpensiMark from 'expensify-common/lib/ExpensiMark';
import Str from 'expensify-common/lib/str';
import {
Clipboard as ClipboardIcon, LinkCopy, Mail, Pencil, Trashcan, Checkmark,
Expand Down Expand Up @@ -153,7 +154,8 @@ class ReportActionContextMenu extends React.Component {
*/
getActionText() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change the method description here to:

Gets the markdown version of the message in an action.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump – this method doc is no longer accurate

const message = _.last(lodashGet(this.props.reportAction, 'message', null));
return lodashGet(message, 'text', '');
const parser = new ExpensiMark();
return parser.htmlToMarkdown(lodashGet(message, 'html', ''));
}

confirmDeleteAndHideModal() {
Expand Down