Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hoverable Component refactor #31518

Merged
merged 23 commits into from
Nov 30, 2023
Merged

Hoverable Component refactor #31518

merged 23 commits into from
Nov 30, 2023

Commits on Nov 18, 2023

  1. split the Hoverable into Active and Disabled parts

    @kacper-mikolajczak
    kacper-mikolajczak committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    5504cc0 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2023

  1. unset Hovered when document visibility has changed

    @kacper-mikolajczak
    kacper-mikolajczak committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    cb8a310 View commit details
    Browse the repository at this point in the history

  2. Add missing clarifying comment

    @kacper-mikolajczak
    kacper-mikolajczak committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    8669939 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. remove onMouse* props from Hoverable

    @kacper-mikolajczak
    kacper-mikolajczak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    87d8979 View commit details
    Browse the repository at this point in the history

  2. remove unused props

    @kacper-mikolajczak
    kacper-mikolajczak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    a78b9f8 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. add has hover support in condition

    @kacper-mikolajczak
    kacper-mikolajczak committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    772fae1 View commit details
    Browse the repository at this point in the history

  2. add unsetHoveredIfOutside functionality

    @kacper-mikolajczak
    kacper-mikolajczak committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    8276438 View commit details
    Browse the repository at this point in the history

  3. add onBlur handler

    @kacper-mikolajczak
    kacper-mikolajczak committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    1f910d2 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2023

  1. change generic type to HTMLElement

    @kacper-mikolajczak
    kacper-mikolajczak committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    0129ddb View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2023

  1. simplify unsetHoveredIfOutside listener

    @kacper-mikolajczak
    kacper-mikolajczak committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    a2bf1a5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into refactor/hoverable-component

    @kacper-mikolajczak
    kacper-mikolajczak committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    cb964d5 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. replace ternary with if statement

    @kacper-mikolajczak
    kacper-mikolajczak committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    dfa7be4 View commit details
    Browse the repository at this point in the history

  2. use RefCallback instead of annonymous function type

    @kacper-mikolajczak
    kacper-mikolajczak committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    88bb94c View commit details
    Browse the repository at this point in the history

  3. make deps with child props more precise

    @kacper-mikolajczak
    kacper-mikolajczak committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    e0fe2e5 View commit details
    Browse the repository at this point in the history

  4. rename events callbacks names

    @kacper-mikolajczak
    kacper-mikolajczak committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    4b49dc2 View commit details
    Browse the repository at this point in the history

  5. rename events callbacks

    @kacper-mikolajczak
    kacper-mikolajczak committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    182fd8d View commit details
    Browse the repository at this point in the history

  6. rename isScrolling to isScrollingRef

    @kacper-mikolajczak
    kacper-mikolajczak committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    60bc902 View commit details
    Browse the repository at this point in the history

  7. change ref to elementRef

    @kacper-mikolajczak
    kacper-mikolajczak committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    c63786a View commit details
    Browse the repository at this point in the history

  8. add a new line between description and params in jsdoc

    @kacper-mikolajczak
    kacper-mikolajczak committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    5464c33 View commit details
    Browse the repository at this point in the history

  9. extract assignRef

    @kacper-mikolajczak
    kacper-mikolajczak committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    963c6d0 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. change assignRef description

    @kacper-mikolajczak
    kacper-mikolajczak committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    81c8e42 View commit details
    Browse the repository at this point in the history

  2. Update src/components/Hoverable/ActiveHoverable.tsx 

    Co-authored-by: Vit Horacek <36083550+mountiny@users.noreply.github.com>
    @kacper-mikolajczak @mountiny
    kacper-mikolajczak and mountiny authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    2dd8968 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2023

  1. rename disabled to isDisabled

    @kacper-mikolajczak
    kacper-mikolajczak committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    783c64a View commit details
    Browse the repository at this point in the history