Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fall back to login as display name when we have it #31275

Merged
merged 7 commits into from
Nov 16, 2023
Merged

Fall back to login as display name when we have it #31275

merged 7 commits into from
Nov 16, 2023

Commits on Nov 13, 2023

  1. Fallback to login if we have it

    @puneetlath
    puneetlath committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    a196af8 View commit details
    Browse the repository at this point in the history

  2. Remove unneeded isOptimisticPersonalDetail logic

    @puneetlath
    puneetlath committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    040e2a2 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. Make displayName optional on PersonalDetails type

    @puneetlath
    puneetlath committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    293f176 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into puneet-displayName-default

    @puneetlath
    puneetlath committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    1450fe6 View commit details
    Browse the repository at this point in the history

  3. Handle potentially undefined displayName in extractFirstAndLastNameFr… 

    …omAvailableDetails
    @puneetlath
    puneetlath committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    4d0877a View commit details
    Browse the repository at this point in the history

  4. Fix optimistic check

    @puneetlath
    puneetlath committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    575e69b View commit details
    Browse the repository at this point in the history

  5. move formatted login check

    @puneetlath
    puneetlath committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    0a67225 View commit details
    Browse the repository at this point in the history