Make comments start at bottom of container #311
Conversation
| @@ -142,7 +142,9 @@ class ReportHistoryView extends React.Component { | |||
| onContentSizeChange={this.scrollToListBottom} | |||
| bounces={false} | |||
| contentContainerStyle={{ | |||
| paddingVertical: 16 | |||
| flexGrow: 1, | |||
There was a problem hiding this comment.
I think these can be referenced like our other styles, so how about moving these into the stylesheet?
There was a problem hiding this comment.
That would work. I think paddingVertical has to be referenced as a contentContainerStyle
This is a little over my head, but can you check this doc and let me know if we can take the styles.whatever approach for the other rules? https://reactnative.dev/docs/scrollview
There was a problem hiding this comment.
Yep, I looked at that, and it should work to use our normal styles.whatever 👍
The paddingVertical is fine to put into styles.whatever and looks like it will work for anything. The docs say it's a shorthand for specifying top and bottom padding: https://reactnative.dev/docs/layout-props#paddingvertical
There was a problem hiding this comment.
Hmm so I'm running into this when trying to apply a styles.whatever to the ScrollView container:
There was a problem hiding this comment.
Ah nvm - contentContainerStyle={[styles.chatContentScrollView]} seems to do the trick!
|
Updated! |
|
Ah, I see conflicts now... one moment. |
@tgolen @marcaaron will you please test and review? This makes comments start at the bottom of the scroll view container, so when you start a new chat with someone, everything is bottom-docked until it eventually scrolls.
Tests: