Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NoQA] Revert "perf: refactor heavy operations when user starts to type" #30852

Merged
merged 1 commit into from
Nov 3, 2023
Merged

[NoQA] Revert "perf: refactor heavy operations when user starts to type" #30852

merged 1 commit into from
Nov 3, 2023

Conversation

mountiny
Copy link
Contributor

@mountiny mountiny commented Nov 3, 2023

Starigt revert Reverts #28469

cc @hurali97 @robertKozik @situchan its late on Friday so just doing a straight revert and we can handle this later next week

@mountiny mountiny self-assigned this Nov 3, 2023
@mountiny mountiny requested a review from a team as a code owner November 3, 2023 14:44
@mountiny mountiny changed the title Revert "perf: refactor heavy operations when user starts to type" [NoQA] Revert "perf: refactor heavy operations when user starts to type" Nov 3, 2023
@melvin-bot melvin-bot bot requested review from stitesExpensify and removed request for a team November 3, 2023 14:45
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 3, 2023

@stitesExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@situchan situchan mentioned this pull request Nov 3, 2023
Merged
59 tasks
@mountiny mountiny merged commit 2133bef into main Nov 3, 2023
12 of 17 checks passed
@mountiny mountiny deleted the revert-28469-perf/refactor-heavy-operations-for-draft branch November 3, 2023 14:55
@melvin-bot melvin-bot bot added the Emergency label Nov 3, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 3, 2023

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny mountiny removed the Emergency label Nov 3, 2023
@mountiny
Copy link
Contributor Author

mountiny commented Nov 3, 2023

Staright revert

@OSBotify
Copy link
Contributor

OSBotify commented Nov 3, 2023

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@aimane-chnaif aimane-chnaif mentioned this pull request Nov 3, 2023
Closed
59 tasks
@OSBotify OSBotify mentioned this pull request Nov 6, 2023
Closed
@OSBotify
Copy link
Contributor

OSBotify commented Nov 6, 2023

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.96-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Nov 8, 2023
Closed
@OSBotify
Copy link
Contributor

OSBotify commented Nov 9, 2023

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.96-15 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.97-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwiznia iwiznia iwiznia approved these changes

@Beamanator Beamanator Beamanator approved these changes

@stitesExpensify stitesExpensify Awaiting requested review from stitesExpensify

Assignees

@mountiny mountiny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mountiny @OSBotify @iwiznia @Beamanator