Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TS Migration] Migrate Icon to TypeScript #30579

Merged
merged 18 commits into from
Nov 10, 2023
Merged

[TS Migration] Migrate Icon to TypeScript #30579

merged 18 commits into from
Nov 10, 2023

Commits on Oct 30, 2023

  1. migrate files that export images to TypeScript

    @JKobrynski
    JKobrynski committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    5039d56 View commit details
    Browse the repository at this point in the history

  2. migrate Icon and LoungeAccessIcon to TypeScript

    @JKobrynski
    JKobrynski committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    af9823a View commit details
    Browse the repository at this point in the history

  3. migrate Expensicons.js to TypeScript

    @JKobrynski
    JKobrynski committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    a6f68b6 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. Merge branch 'main' into migrateIconToTypeScript

    @JKobrynski
    JKobrynski committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    6855dc5 View commit details
    Browse the repository at this point in the history

  2. minor changes

    @JKobrynski
    JKobrynski committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    babfb96 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. improve Icon types, fix linting

    @JKobrynski
    JKobrynski committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    eb6648f View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. create common types file for IconWrapperStyles

    @JKobrynski
    JKobrynski committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    4df669d View commit details
    Browse the repository at this point in the history

  2. augment react-native-svg types to include web properties

    @JKobrynski
    JKobrynski committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    e67fb8e View commit details
    Browse the repository at this point in the history

  3. add missing props to LoungeAccessIcon

    @JKobrynski
    JKobrynski committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    9bedad8 View commit details
    Browse the repository at this point in the history

  4. modify augmented types

    @JKobrynski
    JKobrynski committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    002bfc5 View commit details
    Browse the repository at this point in the history

  5. fix tests

    @JKobrynski
    JKobrynski committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    236a415 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. fix jest mock

    @JKobrynski
    JKobrynski committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    da1441a View commit details
    Browse the repository at this point in the history

  2. apply another fix to jest mock

    @JKobrynski
    JKobrynski committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    3849581 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. remove redundant default props from LoungeAccessIcon

    @JKobrynski
    JKobrynski committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    80fcf73 View commit details
    Browse the repository at this point in the history

  2. bring back comment to Expensicons mock

    @JKobrynski
    JKobrynski committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    ec00063 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. Merge branch 'main' into migrateIconToTypeScript

    @JKobrynski
    JKobrynski committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    edbf015 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into migrateIconToTypeScript

    @JKobrynski
    JKobrynski committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    b0be474 View commit details
    Browse the repository at this point in the history

  3. fix type error

    @JKobrynski
    JKobrynski committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    0d05be8 View commit details
    Browse the repository at this point in the history